-
-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated from CRA to vite and updated typescript to latest #2268
Migrated from CRA to vite and updated typescript to latest #2268
Conversation
WalkthroughThe pull request introduces significant updates to the project's configuration and dependencies, transitioning from Create React App to Vite as the primary build tool. Key changes include the addition of Babel configuration for modern JavaScript, TypeScript, and React support, updates to Jest testing configurations, and the restructuring of the Changes
Assessment against linked issues
Possibly related PRs
Poem
Recent review detailsConfiguration used: .coderabbit.yaml Files ignored due to path filters (1)
Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2268 +/- ##
========================================
Coverage 97.54% 97.54%
========================================
Files 241 241
Lines 6887 6887
Branches 2016 2016
========================================
Hits 6718 6718
Misses 157 157
Partials 12 12 ☔ View full report in Codecov by Sentry. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This is a necessary change.
Some minor questions to create an ideal outcome.
babel.config.cjs
Outdated
presets: [ | ||
'@babel/preset-env', // Transforms modern JavaScript | ||
'@babel/preset-typescript', // Transforms TypeScript | ||
'@babel/preset-react', // Transforms JSX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Can this file be placed in a
.config
orconfig
directory like we have done with the API? - It'll reduce the clutter in the root directory
vite.config.ts
Outdated
import react from '@vitejs/plugin-react'; | ||
import viteTsconfigPaths from 'vite-tsconfig-paths'; | ||
import svgrPlugin from 'vite-plugin-svgr'; | ||
import EnvironmentPlugin from 'vite-plugin-environment'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Can this file be placed in a
.config
orconfig
directory like we have done with the API? - It'll reduce the clutter in the root directory
I'll try to make the required changes. Please ignore the request for review. I clicked it by mistake. |
@palisadoes I have made the changes. |
Please fix the conflicting files |
12a4a00
01ef5c6
into
PalisadoesFoundation:develop
Issue Number:
Fixes #1864
Fixes #2016
I am not assigned to the following issue but this PR automatically fixed it
Fixes #1921
Fixes #2255
Did you add tests for your changes?
Yes
Snapshots/Videos:
#1921 fixes depreciation warnings
If relevant, did you update the documentation?
Not required
Does this PR introduce a breaking change?
Yes
Other information
Have you read the contributing guide?
Yes
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes
Chores
Documentation