Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign of Posts screen for talawa user portal. #1896

Merged
merged 62 commits into from
May 11, 2024

Conversation

git-init-priyanshu
Copy link
Member

@git-init-priyanshu git-init-priyanshu commented Apr 10, 2024

What kind of change does this PR introduce?
UI redesign.

Issue Number:

Fixes #1514

Did you add tests for your changes?
Not yet.

Snapshots/Videos:

https://github.com/PalisadoesFoundation/talawa-admin/assets/110045644/fd3fe77f-dcf1-4a56-b427-44c369cd5cf3
image

image

If relevant, did you update the documentation?
No.

Summary

Does this PR introduce a breaking change?
No.

Other information
This PR is still in progress.

Have you read the contributing guide?
Yes.

git-init-priyanshu and others added 30 commits January 26, 2024 21:28
@git-init-priyanshu
Copy link
Member Author

Should I also add functionality to these dropdown items?
image

@palisadoes
Copy link
Contributor

Don't have the share, and pin post icons.

  1. Pinned posts are only for Admins via the Admin portal.
  2. We can add sharing at a later stage.

@pranshugupta54
Copy link
Member

Please fix type errors

@palisadoes
Copy link
Contributor

Please fix the failing tests

@palisadoes palisadoes linked an issue Apr 21, 2024 that may be closed by this pull request
Copy link

github-actions bot commented May 2, 2024

This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work.

@github-actions github-actions bot added the no-pr-activity No pull request activity label May 2, 2024
@palisadoes
Copy link
Contributor

Please fix the failing test

@github-actions github-actions bot removed the no-pr-activity No pull request activity label May 6, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 97.64706% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 98.23%. Comparing base (872414a) to head (30261c3).

❗ Current head 30261c3 differs from pull request most recent head b73be99. Consider uploading reports for the commit b73be99 to get more accurate results

Files Patch % Lines
src/screens/UserPortal/Posts/Posts.tsx 95.45% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1896      +/-   ##
===========================================
- Coverage    98.26%   98.23%   -0.03%     
===========================================
  Files          210      210              
  Lines         5693     5724      +31     
  Branches      1703     1706       +3     
===========================================
+ Hits          5594     5623      +29     
- Misses          93       95       +2     
  Partials         6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@git-init-priyanshu
Copy link
Member Author

Please do not merge this PR right now. I am adding edit post and delete post functionalities.

@git-init-priyanshu
Copy link
Member Author

This PR is ready to merge now If everything seems fine.

@palisadoes palisadoes merged commit 843d265 into PalisadoesFoundation:develop May 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USER REDESIGN: redesign the Posts screen for the talawa user portal
6 participants