Configurable Session timeout for Community #2186
Conversation
…session management hook
WalkthroughThe recent changes involve updates to the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
Outside diff range, codebase verification and nitpick comments (1)
src/components/UpdateSession/UpdateSession.tsx (1)
19-22: Consider initializing state with null instead of undefined.Using
nullfor initial state values can be more semantically meaningful when representing the absence of data.- const [timeout, setTimeout] = useState<number | undefined>(30); - const [communityTimeout, setCommunityTimeout] = useState<number | undefined>(30); + const [timeout, setTimeout] = useState<number | null>(30); + const [communityTimeout, setCommunityTimeout] = useState<number | null>(30);
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
Files selected for processing (11)
- package.json (2 hunks)
- src/GraphQl/Mutations/mutations.ts (1 hunks)
- src/GraphQl/Queries/Queries.ts (1 hunks)
- src/components/ProfileDropdown/ProfileDropdown.tsx (3 hunks)
- src/components/UpdateSession/UpdateSession.css (1 hunks)
- src/components/UpdateSession/UpdateSession.test.tsx (1 hunks)
- src/components/UpdateSession/UpdateSession.tsx (1 hunks)
- src/screens/CommunityProfile/CommunityProfile.tsx (2 hunks)
- src/screens/LoginPage/LoginPage.tsx (5 hunks)
- src/utils/useSession.test.tsx (1 hunks)
- src/utils/useSession.tsx (1 hunks)
Files skipped from review due to trivial changes (1)
- src/components/UpdateSession/UpdateSession.css
Additional context used
Biome
src/screens/CommunityProfile/CommunityProfile.tsx
[error] 269-269: Change to an optional chain.
Unsafe fix: Change to an optional chain.
(lint/complexity/useOptionalChain)
Additional comments not posted (32)
src/utils/useSession.tsx (11)
1-8: Ensure all imports are necessary and correctly used.The imports seem appropriate for the functionality provided. However, ensure that all imported modules are necessary and used correctly in the file.
10-14: Type definition forUseSessionReturnTypeis clear and appropriate.The type definition for
UseSessionReturnTypeaccurately reflects the functions returned by theuseSessionhook. This enhances type safety and clarity.
16-36: Review the initialization and update of session timeout.The session timeout is initialized with a default value and updated based on query data. This is a good practice for handling asynchronous data fetching.
39-42:resetTimersfunction is correctly implemented.The function clears both session and warning timers, which is crucial for preventing memory leaks and ensuring timers are correctly reset.
44-48:endSessionfunction effectively removes event listeners.This function ensures that event listeners are removed, which is important for preventing memory leaks and unintended behavior.
65-79:initializeTimersfunction is well-structured.The function correctly sets up warning and session timeout timers, providing user feedback through toast notifications. This is a good practice for enhancing user experience.
81-84:extendSessioneffectively resets and reinitializes timers.This function ensures that user activity extends the session, which is essential for dynamic session management.
86-91:startSessionsets up session management effectively.The function correctly initializes timers and sets up event listeners, ensuring that the session is managed dynamically based on user activity.
93-95: Cleanup inuseEffectis correctly implemented.The cleanup function in
useEffectensures that the session is ended when the component is unmounted, preventing potential memory leaks.
97-98: Return statement is clear and concise.The hook returns the necessary functions for session management, making it easy to integrate into other components.
100-100: Export statement is correctly implemented.The default export of the
useSessionhook is appropriate for its intended use as a utility.src/components/ProfileDropdown/ProfileDropdown.tsx (2)
10-10: Import ofuseSessionis correctly added.The import statement for
useSessionis necessary for integrating session management into the component.
28-28: Integration ofendSessionenhances logout functionality.The addition of
endSessionin the logout process ensures that the session is properly terminated, which is crucial for security.package.json (2)
23-23: Addition of@testing-library/react-hooksis beneficial.This addition enhances the project's testing capabilities, allowing for more comprehensive testing of React hooks.
54-54: Update ofreact-tooltipto version^5.28.0.Ensure that the update is compatible with the current codebase and does not introduce breaking changes.
src/utils/useSession.test.tsx (4)
67-83: Test case approved: Session timeout setting.The test case correctly verifies that the session timeout is set based on fetched data.
85-106: Test case approved: Error handling on query error.The test case correctly verifies that the
errorHandleris called when a query error occurs.
108-132: Test case approved: Logout and token revocation.The test case correctly verifies the logout functionality and token revocation process.
134-162: Test case approved: Event listener removal on session end.The test case correctly verifies that event listeners are removed when the session ends.
src/components/UpdateSession/UpdateSession.test.tsx (5)
79-111: Test case approved: Component rendering.The test case correctly verifies the rendering of the
UpdateTimeoutcomponent and its elements.
113-140: Test case approved: Session timeout update.The test case correctly verifies the session timeout update and the success toast.
142-165: Test case approved: Query error handling.The test case correctly verifies that the
errorHandleris called on query errors.
167-218: Test case approved: Update error handling.The test case correctly verifies that the
errorHandleris called on update errors.
220-256: Test case approved: Handling null community object.The test case correctly verifies that the component handles a null community object gracefully.
src/GraphQl/Queries/Queries.ts (1)
780-786: New GraphQL Query Added:GET_COMMUNITY_SESSION_TIMEOUT_DATA.The addition of this query allows retrieval of session timeout data, which aligns with the PR's objective to enhance session management. Ensure that the backend resolver for
getCommunityDatasupports thetimeoutfield.src/screens/CommunityProfile/CommunityProfile.tsx (2)
23-23: New Component Import:UpdateSession.The addition of this import indicates the integration of session update functionality in the
CommunityProfilecomponent. Ensure that theUpdateSessioncomponent is properly implemented and tested.
422-422: Integration ofUpdateSessionComponent.The
UpdateSessioncomponent is now part of theCommunityProfilecomponent, enhancing session management capabilities. Verify that its integration does not introduce any UI or functional issues.Verification successful
Integration of
UpdateSessionComponent VerifiedThe
UpdateSessioncomponent is correctly integrated into theCommunityProfilecomponent, as evidenced by its import and usage. Ensure there are no conflicts with similarly named imports likeUpdateTimeout.
UpdateSessionis imported from../../components/UpdateSession/UpdateSession.- It is used in the JSX of
CommunityProfile.tsx.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the `UpdateSession` component integration in `CommunityProfile`. # Test: Check the usage of `UpdateSession` component. Expect: Proper integration without errors. rg --type tsx 'UpdateSession'Length of output: 57
Script:
#!/bin/bash # Description: Verify the `UpdateSession` component integration in `CommunityProfile`. # Test: Check for the import and usage of `UpdateSession` component in `CommunityProfile.tsx`. fd --type f --extension tsx --exec rg 'UpdateSession' {}Length of output: 231
src/GraphQl/Mutations/mutations.ts (1)
649-653: New GraphQL Mutation Added:UPDATE_SESSION_TIMEOUT.This mutation enables updating the session timeout, supporting the PR's objective of configurable session management. Ensure that the backend resolver for
updateSessionTimeoutis implemented and tested.src/screens/LoginPage/LoginPage.tsx (4)
37-37: Verify the import path foruseSession.Ensure that the path
'utils/useSession'is correct and consistent with the project's file structure.Verification successful
The import path for
useSessionis correct.The file
useSession.tsxexists at the expected location, confirming that the import statement is accurate.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of `useSession` in the specified path. # Test: Check if the file exists in the expected location. fd 'useSession.ts' --exec echo "File exists at: {}"Length of output: 94
333-333: LGTM! Verify session starting after login.The invocation of
startSessionafter successful login and navigation looks good.Ensure that the session is correctly initialized and any necessary cleanup is performed.
Verification successful
Session Initialization Verified in Login Process
The
startSessionfunction is correctly defined and integrated into the login process. It is responsible for initializing session-related activities and is invoked appropriately after a successful login.
startSessionis defined insrc/utils/useSession.tsx.- It is imported and used in
src/screens/LoginPage/LoginPage.tsx.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the session starting process after login. # Test: Check for any cleanup or initialization tasks in `startSession`. ast-grep --lang typescript --pattern $'function startSession($_) { $$$ }'Length of output: 74
Script:
#!/bin/bash # Search for the definition of the `startSession` function in the codebase. ast-grep --lang typescript --pattern 'function startSession($_) { $$$ }' # Search for any import statements related to `startSession`. rg 'startSession' -A 2Length of output: 1558
115-118: LGTM! Verify session starting logic.The logic for starting a session when a user is logged in looks good.
Ensure that the
startSessionfunction is correctly implemented and handles all necessary session initialization tasks.Verification successful
Session Initialization Logic Verified
The
startSessionfunction is implemented as part of a custom hook insrc/utils/useSession.tsx. It correctly handles session initialization tasks such as resetting timers and adding event listeners. This aligns well with the session management requirements in theLoginPagecomponent.
- File:
src/utils/useSession.tsx- Function:
startSessionThe session starting logic in the
LoginPagecomponent is correctly implemented.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the implementation of `startSession`. # Test: Check the implementation of `startSession` to ensure it initializes sessions correctly. ast-grep --lang typescript --pattern $'function startSession($_) { $$$ }'Length of output: 74
Script:
#!/bin/bash # Description: Search for `startSession` across the codebase to identify its implementation. # Search for `startSession` function or method definitions. rg 'startSession' -A 5 # Check if `startSession` is imported from another module. rg 'import.*startSession'Length of output: 2947
136-136: LGTM! Verify destructuring ofuseSession.The destructuring and invocation of
startSessionafter a successful login look good.Ensure that
useSessionreturns the expected object structure.Verification successful
Destructuring of
useSessionis correct. TheuseSessionfunction correctly returns an object containingstartSession, validating its usage inLoginPage.tsx.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the structure returned by `useSession`. # Test: Check the return structure of `useSession` to ensure it includes `startSession`. ast-grep --lang typescript --pattern $'const useSession = () => { return { startSession: $_, $$$ } }'Length of output: 102
Script:
#!/bin/bash # Description: Search for the `useSession` function definition and examine its return structure. # Find the file containing the `useSession` function definition. rg 'function useSession|const useSession =' -A 5 --type=typescriptLength of output: 103
Script:
#!/bin/bash # Description: Search for the `useSession` function definition and examine its return structure. # Find the file containing the `useSession` function definition. rg 'function useSession|const useSession =' -A 5 --type=tsLength of output: 488
Script:
#!/bin/bash # Description: Examine the return structure of the `useSession` function to verify the presence of `startSession`. # Search for the return statement in the `useSession` function. rg 'return {' -A 10 src/utils/useSession.tsxLength of output: 126
Script:
#!/bin/bash # Description: Examine the return structure of the `useSession` function to verify the presence of `startSession`. # Search for the return statement in the `useSession` function with escaped curly braces. rg 'return \{' -A 10 src/utils/useSession.tsxLength of output: 131
|
@JordanCampbell1 Can you fix the failed test application test? |
sure I will take a look |
|
finished up on the fixes, waiting for review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2186 +/- ##
===========================================
+ Coverage 97.54% 97.62% +0.07%
===========================================
Files 242 250 +8
Lines 6888 7188 +300
Branches 2015 2069 +54
===========================================
+ Hits 6719 7017 +298
- Misses 157 159 +2
Partials 12 12 ☔ View full report in Codecov by Sentry. |
|
@JordanCampbell1 Can you fix merge conflicts? |
…awa-admin into session-timeout
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
Files selected for processing (10)
- package.json (2 hunks)
- schema.graphql (2 hunks)
- src/GraphQl/Queries/Queries.ts (1 hunks)
- src/components/ProfileDropdown/ProfileDropdown.test.tsx (3 hunks)
- src/components/ProfileDropdown/ProfileDropdown.tsx (3 hunks)
- src/components/UpdateSession/UpdateSession.tsx (1 hunks)
- src/screens/CommunityProfile/CommunityProfile.tsx (2 hunks)
- src/screens/LoginPage/LoginPage.tsx (5 hunks)
- src/utils/useSession.test.tsx (1 hunks)
- src/utils/useSession.tsx (1 hunks)
Files skipped from review due to trivial changes (2)
- package.json
- src/utils/useSession.tsx
Files skipped from review as they are similar to previous changes (4)
- src/GraphQl/Queries/Queries.ts
- src/screens/CommunityProfile/CommunityProfile.tsx
- src/screens/LoginPage/LoginPage.tsx
- src/utils/useSession.test.tsx
Additional context used
Biome
src/components/UpdateSession/UpdateSession.tsx
[error] 60-60: isNaN is unsafe. It attempts a type coercion. Use Number.isNaN instead.
See the MDN documentation for more details.
Unsafe fix: Use Number.isNaN instead.(lint/suspicious/noGlobalIsNan)
Additional comments not posted (7)
src/components/ProfileDropdown/ProfileDropdown.test.tsx (1)
12-12: Mock setup forGET_COMMUNITY_SESSION_TIMEOUT_DATAis correctly integrated.The mock response for the
GET_COMMUNITY_SESSION_TIMEOUT_DATAquery is well-defined, simulating a timeout value of 30 with a delay of 1000 milliseconds. This setup enhances the test coverage by incorporating a new data retrieval scenario.Also applies to: 26-38
src/components/ProfileDropdown/ProfileDropdown.tsx (1)
10-10: Integration ofendSessionin the logout process is correct.The
endSessionmethod is appropriately called after clearing local storage and before redirecting to the home page, ensuring a secure and orderly termination of the user session.Also applies to: 25-50
src/components/UpdateSession/UpdateSession.tsx (3)
52-66: Type safety inhandleOnChangeis well-implemented.The use of a type guard ensures that the event is handled safely, preventing runtime errors.
Tools
Biome
[error] 60-60: isNaN is unsafe. It attempts a type coercion. Use Number.isNaN instead.
See the MDN documentation for more details.
Unsafe fix: Use Number.isNaN instead.(lint/suspicious/noGlobalIsNan)
68-85: Error handling inhandleOnSubmitis robust.The try-catch block effectively captures and handles errors, ensuring that any issues during the mutation process are managed gracefully.
87-89: Loader rendering logic is correct.The loader is appropriately displayed when the
loadingstate is true, providing visual feedback during data fetching.schema.graphql (2)
164-171: TheCommunitytype is well-defined.The fields
_id,logoUrl,name,socialMediaUrls,timeout, andwebsiteLinkare relevant and correctly defined for representing community-related data.
781-781: TheupdateSessionTimeoutmutation is correctly defined.The mutation accepts a
timeoutparameter and returns a Boolean, facilitating the update of session timeout settings effectively.
|
just fixed it @varshith257 |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- src/components/UpdateSession/UpdateSession.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- src/components/UpdateSession/UpdateSession.tsx
|
@DMills27 @aashimawadhwa Please review |
…awa-admin into session-timeout
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
Files selected for processing (1)
- package.json (2 hunks)
Files skipped from review due to trivial changes (1)
- package.json
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- src/components/UpdateSession/UpdateSession.tsx (1 hunks)
- src/utils/useSession.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- src/components/UpdateSession/UpdateSession.tsx
- src/utils/useSession.tsx
|
@palisadoes made the PR for the develop branch for the admin as well |
…awa-admin into session-timeout
…awa-admin into session-timeout
…awa-admin into session-timeout
|
@DMills27 @aashimawadhwa Please review |
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Outside diff range and nitpick comments (1)
schema.graphql (1)
Line range hint
653-657: Adding required parameterisDisabledmay introduce breaking changesThe
createActionItemCategorymutation now includes a new required parameterisDisabled: Boolean!. This change can break existing clients that do not provide this parameter.To maintain backward compatibility, consider one of the following options:
- Make
isDisabledoptional by changing its type toBoolean.- Provide a default value for
isDisabledin the resolver when the parameter is not provided.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (2)
- schema.graphql (3 hunks)
- src/GraphQl/Mutations/ActionItemCategoryMutations.ts (1 hunks)
🧰 Additional context used
…awa-admin into session-timeout
|
@JordanCampbell1 please fix the conflicts and the failing tests. |
…awa-admin into session-timeoutand adjusted test and componenet files to new graphql parameter
|
@palisadoes @DMills27 @aashimawadhwa fixed all issues, should be ready for merge now |
There was a problem hiding this comment.
Actionable comments posted: 12
🧹 Outside diff range and nitpick comments (7)
src/components/OrgActionItemCategories/OrgActionItemCategoryMocks.ts (2)
1-101: LGTM! Consider adding JSDoc comments for better documentation.The imports and MOCKS constant declaration look good. The mock data structure is well-organized and covers various scenarios for action item category operations.
Consider adding JSDoc comments to describe the purpose of the MOCKS constant and its structure. This would enhance code readability and maintainability. For example:
/** * Mock data for action item category GraphQL operations. * Includes mocks for querying categories and creating/updating them. */ export const MOCKS = [ // ... existing code ... ];
1-182: Great job on the mock data structure! Consider adding type annotations.Overall, this file provides a comprehensive set of mock data for testing action item category-related GraphQL operations. The separation of successful and error scenarios is well-thought-out and will be valuable for thorough testing.
To further improve the file, consider adding type annotations to the exported constants. This would enhance type safety and make the structure of the mock data more explicit. For example:
import { GraphQLError } from 'graphql'; type MockData = { request: { query: any; variables: Record<string, any>; }; result?: { data: Record<string, any>; }; error?: GraphQLError; }[]; export const MOCKS: MockData = [ // ... existing code ... ]; export const MOCKS_ERROR_QUERY: MockData = [ // ... existing code ... ]; export const MOCKS_ERROR_MUTATIONS: MockData = [ // ... existing code ... ];This addition would make the code more robust and self-documenting.
src/components/OrgActionItemCategories/OrgActionItemCategories.tsx (2)
276-276: UseonSubmitinstead ofonSubmitCaptureunless necessaryAt line 276, the
onSubmitCaptureevent handler is used in the<Form>component. Unless there's a specific reason to handle the submit event during the capturing phase, it's recommended to useonSubmitfor standard form submission handling.Apply this diff to make the change:
- onSubmitCapture={modalType === 'Create' ? handleCreate : handleEdit} + onSubmit={modalType === 'Create' ? handleCreate : handleEdit}
303-303: Add test coverage for thedisabledStatustoggleLine 303 is not covered by tests according to the static analysis hints. Adding a unit test for the
disabledStatustoggle will improve test coverage and ensure it functions as expected.Would you like assistance in writing the unit test for this functionality?
🧰 Tools
🪛 GitHub Check: codecov/patch
[warning] 303-303: src/components/OrgActionItemCategories/OrgActionItemCategories.tsx#L303
Added line #L303 was not covered by testssrc/components/OrgActionItemCategories/OrgActionItemCategories.test.tsx (3)
313-313: Correct typo in test descriptionThere's a typo in the test description at line 313. The word "disablity" should be "disability".
Apply this change:
- test('toggle the disablity status of an action item category', async () => { + test('toggle the disability status of an action item category', async () => {
346-346: Correct typo in test descriptionSimilarly, correct the typo in the test description at line 346.
Apply this change:
- test('toast error on unsuccessful toggling of the disablity status', async () => { + test('toast error on unsuccessful toggling of the disability status', async () => {
157-157: Remove commented-out codeThere's commented-out code at line 157. It's good practice to remove unused code to keep the codebase clean.
Apply this diff:
- // userEvent.click(screen.getByTestId('disabledStatusToggle')); // Toggle the disabled status
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (4)
- package.json (1 hunks)
- src/components/OrgActionItemCategories/OrgActionItemCategories.test.tsx (1 hunks)
- src/components/OrgActionItemCategories/OrgActionItemCategories.tsx (1 hunks)
- src/components/OrgActionItemCategories/OrgActionItemCategoryMocks.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- package.json
🧰 Additional context used
📓 Learnings (1)
src/components/OrgActionItemCategories/OrgActionItemCategories.test.tsx (2)
Learnt from: Chaitanya1672 PR: PalisadoesFoundation/talawa-admin#2049 File: src/screens/OrganizationActionItems/ActionItemUpdateModal.tsx:112-138 Timestamp: 2024-07-03T07:40:16.065Z Learning: The `istanbul ignore next` comments in the `ActionItemUpdateModal.tsx` file were added as part of a commit that introduced tests for the `ActionItemUpdateModal` component. Removing these comments and writing tests to cover the previously ignored lines is recommended to ensure code integrity and improve test coverage.Learnt from: Chaitanya1672 PR: PalisadoesFoundation/talawa-admin#2049 File: src/screens/OrganizationActionItems/ActionItemUpdateModal.tsx:112-138 Timestamp: 2024-10-08T16:13:41.996Z Learning: The `istanbul ignore next` comments in the `ActionItemUpdateModal.tsx` file were added as part of a commit that introduced tests for the `ActionItemUpdateModal` component. Removing these comments and writing tests to cover the previously ignored lines is recommended to ensure code integrity and improve test coverage.
🪛 GitHub Check: codecov/patch
src/components/OrgActionItemCategories/OrgActionItemCategories.tsx
[warning] 303-303: src/components/OrgActionItemCategories/OrgActionItemCategories.tsx#L303
Added line #L303 was not covered by tests
🔇 Additional comments (2)
src/components/OrgActionItemCategories/OrgActionItemCategoryMocks.ts (1)
103-111: LGTM! Error query mock is well-structured.The MOCKS_ERROR_QUERY constant is correctly implemented to simulate an error scenario for the action item category list query. This is useful for testing error handling in the application.
src/components/OrgActionItemCategories/OrgActionItemCategories.test.tsx (1)
22-22: Ensure correct import based on export typeAt line 22, ensure that
OrgActionItemCategoriesis imported correctly based on whether it's a default or named export. If it's a named export, it should be imported with curly braces.Please confirm that
OrgActionItemCategoriesis exported as a default export. If it's a named export, adjust the import statement:-import OrgActionItemCategories from './OrgActionItemCategories'; +import { OrgActionItemCategories } from './OrgActionItemCategories';To verify the export, you can check the component file.
DMills27
merged commit 025bc1d
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
Feature: Session Timeout
Issue Number:
Fixes #2151
Did you add tests for your changes?
Yes
Snapshots/Videos:
Summary
Making the change to include a session timeout, hence creating sessions for the application, ensures that there is a layer of security when users use the application. These changes to Talawa Admin will allow configurable logout that affects the community as well as automatic logout when the user is inactive for the selected session timeout period
#2151
Have you read the contributing guide?
Yes
Summary by CodeRabbit
Summary by CodeRabbit
New Features
redux-thunkfor improved management of asynchronous actions in the application.Communitytype and updated mutations in the GraphQL schema for enhanced functionality.Bug Fixes
react-tooltipdependency.Chores