Setup script doesn't handle Docker intuitively

[palisadoes]

Describe the bug

1. The setup script doesn't
   1. remember whether the user running the script previously answered Y to this question:

      Are you setting up this project using Docker? (y/N)
      

   2. doesn't detect whether docker is running the application and if so doesn't prompt the user to import the sample data. This means that the user has to refer to INSTALLATION.md and manually do the importation. This is not a good user experience.

To Reproduce

Steps to reproduce the behavior:

1. Run the setup script, select Docker
2. You never get prompted for data import if docker is running the application
3. The script doesn't store your previous Docker related answers

Expected behavior

1. Run the setup script, select Docker
2. Get prompted for data import if docker is running the application
3. The script stores your previous Docker related answers
4. Sample data is correctly imported
5. Update INSTALLATION.md to:
   1. let people know that after starting docker for the first time that they should run the installation script again
   2. show people how to install sample data from the CLI when docker is being used.
6. There must be a docker specific way to manually import data successfully with appropriate errors if it fails.
7. The existing non-docker data importation script must fail with an appropriate error if the non-docker API instance and database is not. It does not do that now. Docker can be running and the non-docker data importation runs without failing or giving appropriate messaging.
8. Tests are written to ensure the script always has the newly desired behavior

Actual behavior

• See above

Screenshots

Additional details

• N/A

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

• Student Internship Programs talawa#359

[varshith257]

@palisadoes I would like to work on this issue

[palisadoes]

@varshith257 are you still able to work on this?

[github-actions]

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

[palisadoes]

1. Inactive, unassigning
2. Are you still working on this?

[github-actions]

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

[varshith257]

Assigning myself as a first priority issue to solve
cc/ @palisadoes @Cioppolo14

[github-actions]

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

[varshith257]

Working:)

…

On Mon, 24 Jun, 2024, 5:43 am github-actions[bot], ***@***.***> wrote: This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. — Reply to this email directly, view it on GitHub <#2270 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4BF3HBLBG6U5LUOMD2DLQLZI5QDJAVCNFSM6AAAAABG5AHYOGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBVGM3TKMZYGU> . You are receiving this because you were assigned.Message ID: ***@***.***>

[github-actions]

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

[varshith257]

Working with @Cioppolo14

[github-actions]

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

[zakhaev26]

@palisadoes While reviewing the setup.ts script, particularly in the sections configuring environment variables, I noticed that the isDockerInstallation flag introduces a separate program flow. However, when I remove the isDockerInstallation checks, the output behaves as expected, specifically prompting the user to import data even in Docker installations (Y). Could you clarify if there’s a specific reason for handling Docker installations differently? I just want to make sure I’m not overlooking anything important..

I’ve also shared the prompt logs after removing the isDockerInstallation flag in the palisadoes/talawa-api Slack channel for your reference.

[github-actions]

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

[palisadoes]

unassigning, inactivity

[github-actions]

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

[Suyash878]

I would like to work on this

[palisadoes]

During the week of November 11, 2024 we will start a code freeze on the develop branches in Talawa, Talawa Admin and Talawa-API.

We have completed a project to convert the Talawa-API backend to use PostgreSQL. Work will then begin with us merging code in the develop branches to a new develop-postrgres branch in each repository.

Planning activities for this will be managed in our #talawa-projects slack channel. A GitHub project will be created to track specially labeled issues. We completed a similar exercise last year using a similar methodology.

Starting November 12, California time no new PRs will be accepted against the develop branch. They must be applied to the develop-postrgres branch.

There are some GSoC project features that will need to be merged into develop. These will be the only exceptions.

This activity and the post GSoC 2024 start date was announced in our #general Slack channel last month as a pinned post.

[Suyash878]

Are we looking for something of this sort where we just prompt the user to execute the data import command, Or is it expected to run the data import command by itself and not ask the user to manually run it?

[PurnenduMIshra129th]

hi @palisadoes i want to work on all docker related issue on local installation . because i have already faced it and solved this so if u assign this to me then give some time to review it and direct merge it i think it will work.

[Cioppolo14]

If the issue has already been assigned, please don't ask to be assigned. We want everyone to get a chance.

[PurnenduMIshra129th]

@Cioppolo14 no problem previously it is unassigned that's why i commented , i will find another one , thanks for information.

[Suyash878]

I am pretty much done with the changes will be raising a PR soon.

[palisadoes]

Please apply the changes to the develop-postgres branch. We are migrating the backend to that DB.

[Suyash878]

I observed that there is no setup script for the develop-postgres branch and all of my changes have been made in the setup script (ie: setup.ts) for the develop branch, now if I make a PR to the postgres branch it would lead to large amount of conflicts which therefore would lead to the tests failing.
I would like to know how should I proceed with this

[palisadoes]

Apply it to the develop branch and we can then create an issue for someone to use your work to create a setup script for develop-postgres

[PurnenduMIshra129th]

@palisadoes assign this issue to me . As previously faced this issue and choose to set the mongo locally and imported the data then connect with it dockor but this time i will import the data in the mongo image by handling the script.

[PurnenduMIshra129th]

hi @palisadoes assign this issue . Completed this one.Now in docker setup data is importing in mongo image will make one video to post here . review it and guide what needs to be changed.

[palisadoes]

@AVtheking is working on this

[PurnenduMIshra129th]

2024-11-24-02-09-54-1_W7Sg9Ovl.mp4

hi @palisadoes . I uploaded one video of with for setup with docker with importing data with its mongo image. See it only i have done for windows . If u confirm then i will add for windows and mac os . I will make an pull request if u give further instructions to proceed . If @AVtheking completed then no problem u can ignore this .

[github-actions]

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.