Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolvers: Create tests for groups.js #585

Closed
palisadoes opened this issue Feb 24, 2022 · 8 comments · Fixed by #769
Closed

Resolvers: Create tests for groups.js #585

palisadoes opened this issue Feb 24, 2022 · 8 comments · Fixed by #769
Assignees
@SiddheshKukade
Labels
good first issue Good for newcomers test Testing application

Comments

@palisadoes
Copy link
Contributor

The Talawa-API code base needs to be 100% reliable. This means we need to have 100% test code coverage.

Tests need to be written for file lib/resolvers/group_query/groups.js

  • We will need the API to be refactored for all methods, classes and/or functions found in this file for testing to be correctly executed.
  • When complete, all all methods, classes and/or functions in the refactored file will need to be tested. These tests must be placed in a
    single file with the name tests/resolvers/group_query/groups.spec.js. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found here. If the file isn't found in this directory, or there is a 404 error, then tests have not been created.
  • The PR will show a report for the code coverage for the file you have added. You can use that as a guide.
@palisadoes palisadoes added the bug Something isn't working label Feb 24, 2022
@github-actions github-actions bot added parent Parent issue test Testing application unapproved Unapproved for Pull Request labels Feb 24, 2022
@palisadoes palisadoes mentioned this issue Feb 24, 2022
Closed
@palisadoes palisadoes added good first issue Good for newcomers points 02 and removed bug Something isn't working parent Parent issue labels Feb 24, 2022
@arnab15
Copy link
Contributor

arnab15 commented Mar 19, 2022

@palisadoes please assign this issue to me

@palisadoes
Copy link
Contributor Author

You already have two other issues assigned. If they are in a PR, ask for a review in the comments. We need to make everyone have a chance to participate.

@joharikushagra
Copy link

@palisadoes can I work on this issue?

@palisadoes
Copy link
Contributor Author

@arnab15 do you still want to work on this issue?

@arnab15
Copy link
Contributor

arnab15 commented Apr 1, 2022

@palisadoes yes I can assign it to me

@palisadoes palisadoes removed the unapproved Unapproved for Pull Request label Apr 1, 2022
@arnab15
Copy link
Contributor

arnab15 commented May 10, 2022

due to my ongoing semester exam from 2nd May to 21 May, I am not able to contribute to this issue ,after 21May I'll start contributing again.

@rakshitgondwal
Copy link

Hey @palisadoes !!
Can I try contributing to this issue?

@palisadoes palisadoes assigned rakshitgondwal and unassigned arnab15 Sep 11, 2022
@rakshitgondwal rakshitgondwal removed their assignment Sep 13, 2022
@SiddheshKukade
Copy link
Member

@palisadoes I would like to take this sir

This was referenced Sep 16, 2022
Closed
Merged
palisadoes pushed a commit that referenced this issue Sep 19, 2022
@SiddheshKukade
Code Coverage : Tests for groups.js Fix #585 (#769)
7d5babc 
* Create groups.spec.js

* Update groups.spec.js

* Update getPlugins.spec.js
DMills27 pushed a commit that referenced this issue Nov 9, 2022
@xoldd @palisadoes
@dependabot @JamaicanFriedChicken @SiddheshKukade @nishant3721 @ebrahim354 @asmitsirohi @kb-0311
Talawa api typescript migration (#780)
9dd36b3 
* Removed package easygraphql-tester (#747)

Removed the package named easygraphql-tester because it was not being used anywhere in the app and had a security vulnerability.

* Revert "Removed package easygraphql-tester (#747)" (#753)

This reverts commit 61818a1.

* Bump moment-timezone from 0.5.34 to 0.5.37 (#757)

Bumps [moment-timezone](https://github.com/moment/moment-timezone) from 0.5.34 to 0.5.37.
- [Release notes](https://github.com/moment/moment-timezone/releases)
- [Changelog](https://github.com/moment/moment-timezone/blob/develop/changelog.md)
- [Commits](moment/moment-timezone@0.5.34...0.5.37)

---
updated-dependencies:
- dependency-name: moment-timezone
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Doubled the number of retries

The tests have been failing due to timeouts.

* add mongodb credentials in github actions yml file

* update github actions mongodb parameters

* update variable names in github actions

* update github actions push file

* revert github actions push file

* add start period for health check in github actions

* add extra health check parameters for mongo

* adjust mongo image version

* explicitly add mongo version to image for github actions

* Removed package easygraphql-tester (#754)

* Code Coverage : Tests for groups.js Fix #585 (#769)

* Create groups.spec.js

* Update groups.spec.js

* Update getPlugins.spec.js

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Bump jose from 2.0.5 to 2.0.6 (#770)

Bumps [jose](https://github.com/panva/jose) from 2.0.5 to 2.0.6.
- [Release notes](https://github.com/panva/jose/releases)
- [Changelog](https://github.com/panva/jose/blob/v2.0.6/CHANGELOG.md)
- [Commits](panva/jose@v2.0.5...v2.0.6)

---
updated-dependencies:
- dependency-name: jose
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump file-type and image-hash (#752)

Bumps [file-type](https://github.com/sindresorhus/file-type) and [image-hash](https://github.com/danm/image-hash). These dependencies needed to be updated together.

Updates `file-type` from 14.7.1 to 16.5.4
- [Release notes](https://github.com/sindresorhus/file-type/releases)
- [Commits](sindresorhus/file-type@v14.7.1...v16.5.4)

Updates `image-hash` from 4.0.1 to 5.3.1
- [Release notes](https://github.com/danm/image-hash/releases)
- [Commits](https://github.com/danm/image-hash/commits)

---
updated-dependencies:
- dependency-name: file-type
  dependency-type: indirect
- dependency-name: image-hash
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump got and nodemon (#771)

Bumps [got](https://github.com/sindresorhus/got) and [nodemon](https://github.com/remy/nodemon). These dependencies needed to be updated together.

Removes `got`

Updates `nodemon` from 2.0.15 to 2.0.20
- [Release notes](https://github.com/remy/nodemon/releases)
- [Commits](remy/nodemon@v2.0.15...v2.0.20)

---
updated-dependencies:
- dependency-name: got
  dependency-type: indirect
- dependency-name: nodemon
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump vm2 from 3.9.9 to 3.9.11 (#772)

Bumps [vm2](https://github.com/patriksimek/vm2) from 3.9.9 to 3.9.11.
- [Release notes](https://github.com/patriksimek/vm2/releases)
- [Changelog](https://github.com/patriksimek/vm2/blob/master/CHANGELOG.md)
- [Commits](patriksimek/vm2@3.9.9...3.9.11)

---
updated-dependencies:
- dependency-name: vm2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Feature Request :  Performing Donations ( Ability to store donation transaction in Talwa-api )  (#756)

* Test : lib/resolvers/group_chat_query/groupChatMessages.js

* Add Test  : Added Valid JSON Check

* Create README.md

* Create README.md

* Update is-auth.js

* AddedDocs

Docs from withfilter pending

* Update index.js

* completed

* sample

* update/index.js

* update/index.js

* update/is-auth.js

* Update/readme.md

* update/image-readme

* Add/query-schema

* Update/Plugin-graphQL-schema

* Add/Plugin-MongoDB-Model

* Add/createPlugin-and-refractoring

* Add/getPlugins

* Add/Mutation/UpdatePluginStatus

* Add/Mutation/updateTempPluginInstalledOrgs

* Add/Mutation/Schema

* Add/import/mutations

* Add/plugins

* Fix/path-err

* Fix/Erros

* update/lockfile

* Add/plugin-model

* Update is-auth.js

* Removed extra queries

* Documentation added for plugin queries and models

* Fix/`delelte cr in prettier/prettier`

* updated : mutation

* Add/test `getPlugins`

* Fix/`lint error`

* test `updatePluginInstalledOrgs`

* Test/ `updateInstallStatus`

* Fix/Erros-1

* Fix/Erros-2

* Fix/Erros-3

* Test/`Queries.js`

* Test/`Mutation.js`

* remove extra `console.log`

* Delete admin-plugin-query.js

* Delete super-admin-plugin-query.js

* Fix/Package-lock

* Create cancel_membership_request.spec.js

* Update cancel_membership_request.js

* Update cancel_membership_request.spec.js

* Update cancel_membership_request.js

* `Typo`

* Add : Donation Model

* Add : getDonations Query

* Add : Schema for Donation

* Add : Schema for getDonations query

* Add : getDonationById Query

* Add : Schema for getDonationById

* Fix : `Donation Model`

* Add : createDonation Mutation

* Add : createDonation Schema

* Updated Donation Model

* Add :  `createDonation` GraphQL Mutation

* Fix : `getDonationById` Query

* Add : `getDonationByOrgId` Query

* Update : Scehma Updated due to change in `Donation` Model

* Update : `Donation` Schema in .graphql

* Add : `getDonationById` and `getDonationByOrgId` in gql schema

* Add : gql Schema for `DeletePayload`

* Add : `deleteDonationById` Mutation

* Chores : Formatting files

* Fix : Lint errors

* Test for send_membership_request.js (#763)

* test for reject_membership_request.js

* send_membership_request.spec.js initialized

* test for send_membership_request.js

* fixes in test for send membership request

* minor fixes in send_membership_request.spec.js

* 100% test coverage

Co-authored-by: Nishant <srnikhil3721@gmai.com>

* Talawa api multitenancy (#776)

* Initial setup (#726)

* Initial setup

* simplified creation

* added readme.md file

* added connection manager and id helper functions

* Error handling & security updates (#744)

* [Feature Request] New Features for Talawa-admin added (#725)

* check authentication feature added for talawa admin

* tests for check authentication added

* minor fixes

* typo fixes

* minor fixes

* npm err fixes

* google recaptcha configured

* new dependency added

* mailer, forgotPassword endpoint and otp endpoint is configured

* graphql endpoints updated

* constants updated

* Documentation updated

* tests for changes added

* hard coded value error fixes

* lint fixes

* lint fixes

* failed test cases fixes

* Failed tests fixes

* minor fixes

* marked-teminal dependency updated

* Tests fixes

* tests updated

* tests fixes

* tests updated

* new resolvers added and schema updated

* graphql mutations updated

* tests updated for changes

* tests updated

* tests updated

* tests updated

* minor fixes

* [Feature Request] : Plugin Architecture for Server (#730)

* Test : lib/resolvers/group_chat_query/groupChatMessages.js

* Add Test  : Added Valid JSON Check

* Create README.md

* Create README.md

* Update is-auth.js

* AddedDocs

Docs from withfilter pending

* Update index.js

* completed

* sample

* update/index.js

* update/index.js

* update/is-auth.js

* Update/readme.md

* update/image-readme

* Add/query-schema

* Update/Plugin-graphQL-schema

* Add/Plugin-MongoDB-Model

* Add/createPlugin-and-refractoring

* Add/getPlugins

* Add/Mutation/UpdatePluginStatus

* Add/Mutation/updateTempPluginInstalledOrgs

* Add/Mutation/Schema

* Add/import/mutations

* Add/plugins

* Fix/path-err

* Fix/Erros

* update/lockfile

* Add/plugin-model

* Update is-auth.js

* Removed extra queries

* Documentation added for plugin queries and models

* Fix/`delelte cr in prettier/prettier`

* updated : mutation

* Add/test `getPlugins`

* Fix/`lint error`

* test `updatePluginInstalledOrgs`

* Test/ `updateInstallStatus`

* Fix/Erros-1

* Fix/Erros-2

* Fix/Erros-3

* Test/`Queries.js`

* Test/`Mutation.js`

* remove extra `console.log`

* Delete admin-plugin-query.js

* Delete super-admin-plugin-query.js

* Fix/Package-lock

* added delimiter to helper functions

* error handling for connection manager

* added readme.md for connection manager

* error handling for Database module

Co-authored-by: Asmit Kumar Sirohi <63240102+asmitsirohi@users.noreply.github.com>
Co-authored-by: Siddhesh Bhupendra Kuakde <65951872+SiddheshKukade@users.noreply.github.com>

* Create new tenant on createOrganization

* Custom schema functionality

* Added the context function

* modify createPost resolver

* fix createPost, createOrganization resolvers

* Initial setup (#726)

* Initial setup

* simplified creation

* added readme.md file

* added connection manager and id helper functions

* Error handling & security updates (#744)

* [Feature Request] New Features for Talawa-admin added (#725)

* check authentication feature added for talawa admin

* tests for check authentication added

* minor fixes

* typo fixes

* minor fixes

* npm err fixes

* google recaptcha configured

* new dependency added

* mailer, forgotPassword endpoint and otp endpoint is configured

* graphql endpoints updated

* constants updated

* Documentation updated

* tests for changes added

* hard coded value error fixes

* lint fixes

* lint fixes

* failed test cases fixes

* Failed tests fixes

* minor fixes

* marked-teminal dependency updated

* Tests fixes

* tests updated

* tests fixes

* tests updated

* new resolvers added and schema updated

* graphql mutations updated

* tests updated for changes

* tests updated

* tests updated

* tests updated

* minor fixes

* [Feature Request] : Plugin Architecture for Server (#730)

* Test : lib/resolvers/group_chat_query/groupChatMessages.js

* Add Test  : Added Valid JSON Check

* Create README.md

* Create README.md

* Update is-auth.js

* AddedDocs

Docs from withfilter pending

* Update index.js

* completed

* sample

* update/index.js

* update/index.js

* update/is-auth.js

* Update/readme.md

* update/image-readme

* Add/query-schema

* Update/Plugin-graphQL-schema

* Add/Plugin-MongoDB-Model

* Add/createPlugin-and-refractoring

* Add/getPlugins

* Add/Mutation/UpdatePluginStatus

* Add/Mutation/updateTempPluginInstalledOrgs

* Add/Mutation/Schema

* Add/import/mutations

* Add/plugins

* Fix/path-err

* Fix/Erros

* update/lockfile

* Add/plugin-model

* Update is-auth.js

* Removed extra queries

* Documentation added for plugin queries and models

* Fix/`delelte cr in prettier/prettier`

* updated : mutation

* Add/test `getPlugins`

* Fix/`lint error`

* test `updatePluginInstalledOrgs`

* Test/ `updateInstallStatus`

* Fix/Erros-1

* Fix/Erros-2

* Fix/Erros-3

* Test/`Queries.js`

* Test/`Mutation.js`

* remove extra `console.log`

* Delete admin-plugin-query.js

* Delete super-admin-plugin-query.js

* Fix/Package-lock

* added delimiter to helper functions

* error handling for connection manager

* added readme.md for connection manager

* error handling for Database module

Co-authored-by: Asmit Kumar Sirohi <63240102+asmitsirohi@users.noreply.github.com>
Co-authored-by: Siddhesh Bhupendra Kuakde <65951872+SiddheshKukade@users.noreply.github.com>

* dynamic functionality additions

* update tenant schema folder

* modify all posts-comments resolvers

* resolve failing tests for posts modifications

* modify events-tasks-projects related resolvers

* resolve failing tests

* modified user queries

* modify longin mutation to return events properly

* modify org mutations and resolve failing tests

* diconnect properly from the database

* if not connection for org search in the database for it

* group chats and direct chats mutations

* remove console logs

* remove unnecessary comments

* fix drop database

Co-authored-by: Mickey <31347338+JamaicanFriedChicken@users.noreply.github.com>
Co-authored-by: Asmit Kumar Sirohi <63240102+asmitsirohi@users.noreply.github.com>
Co-authored-by: Siddhesh Bhupendra Kuakde <65951872+SiddheshKukade@users.noreply.github.com>
Co-authored-by: JamaicanFriedChicken <mikey_lue777@hotmail.com>

* interchanged .env and .env.sample from the installation guide (#774)

* Migrated develop branch to typescript including the changes till october 19, 2022

* Added some comments and reinstalled some packages to match the main repository's package.json

* Github actions update

* getLanguage.spec.ts import fix

* forgotPassword.spec.ts fix

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Peter Harrison <blackriver@simiya.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: JamaicanFriedChicken <mikey_lue777@hotmail.com>
Co-authored-by: Siddhesh Bhupendra Kuakde <65951872+SiddheshKukade@users.noreply.github.com>
Co-authored-by: Nishant Singh <76558924+nishant3721@users.noreply.github.com>
Co-authored-by: Nishant <srnikhil3721@gmai.com>
Co-authored-by: Ebrahim <74679570+ebrahim354@users.noreply.github.com>
Co-authored-by: Mickey <31347338+JamaicanFriedChicken@users.noreply.github.com>
Co-authored-by: Asmit Kumar Sirohi <63240102+asmitsirohi@users.noreply.github.com>
Co-authored-by: Kanishka Bansode <96020697+kb-0311@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SiddheshKukade SiddheshKukade

Labels
good first issue Good for newcomers test Testing application
Projects
None yet
Milestone
No milestone
5 participants
@palisadoes @arnab15 @joharikushagra @SiddheshKukade @rakshitgondwal