-
-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve and Standardize Automated Linting Tests #1310
Improve and Standardize Automated Linting Tests #1310
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
I opened this PR early. Please give a look at these additional rules. Once they are approved, I will resolve the warnings and clean the code. We can also introduce new rules |
Codecov Report
@@ Coverage Diff @@
## develop #1310 +/- ##
===========================================
- Coverage 99.59% 99.39% -0.21%
===========================================
Files 177 171 -6
Lines 10166 10036 -130
Branches 753 750 -3
===========================================
- Hits 10125 9975 -150
- Misses 41 51 +10
- Partials 0 10 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
These changes are OK. Should this PR be merged? |
Sir, I will make the changes in the codebase with respect to the newly added linting rules; the we can get the PR merged |
Please add the additional code files to this PR |
Is this ready for review now? |
Almost done sir |
Please fix the conflicting files |
Is this ready for review now? |
Yes sir, the PR is ready for review |
Sorry for a late response but there were a lot of errors generated after applying rules and some errors where difficult to solve |
They are still failing. Can you figure out why? |
We have changes in |
What kind of change does this PR introduce? - This PR introduces new linting rules to improve and automate the linting tests. The following rules are added :
Naming Convention :
Array Type
consistent-type-assertions
consistent-type-imports
explicit-function-return-type
typedef
Issue Number: #1275
Fixes #1275
Did you add tests for your changes? Yes
Does this PR introduce a breaking change? No
Have you read the contributing guide? Yes