Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test file for updatePluginStatus.ts #1682

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Test file for updatePluginStatus.ts #1682

merged 5 commits into from
Jan 16, 2024

Conversation

git-init-priyanshu
Copy link
Member

@git-init-priyanshu git-init-priyanshu commented Jan 14, 2024

What kind of change does this PR introduce?
Tests

Issue Number:
Fixes #1681

Did you add tests for your changes?
Yes

Snapshot
Screenshot from 2024-01-14 14-38-11
s/Videos:

If relevant, did you update the documentation?
No

Summary
Added tests for updatePluginStatus.ts file

Does this PR introduce a breaking change?
No

Have you read the contributing guide?
Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 84 lines in your changes are missing coverage. Please review.

Comparison is base (c0468a4) 98.17% compared to head (24d77a5) 98.36%.
Report is 149 commits behind head on develop.

Files Patch % Lines
src/utilities/PII/decryption.ts 0.00% 17 Missing ⚠️
src/resolvers/Mutation/updateUserProfile.ts 70.90% 1 Missing and 15 partials ⚠️
src/resolvers/middleware/currentUserExists.ts 45.83% 13 Missing ⚠️
src/utilities/PII/encryption.ts 0.00% 13 Missing ⚠️
src/utilities/PII/isAuthorised.ts 0.00% 11 Missing ⚠️
src/resolvers/Mutation/createPost.ts 87.23% 6 Missing ⚠️
...tilities/encodedVideoStorage/uploadEncodedVideo.ts 96.29% 3 Missing ⚠️
src/resolvers/Mutation/removeAdvertisement.ts 92.85% 2 Missing ⚠️
...c/resolvers/Query/postsByOrganizationConnection.ts 33.33% 2 Missing ⚠️
src/resolvers/Query/postsByOrganization.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1682      +/-   ##
===========================================
+ Coverage    98.17%   98.36%   +0.18%     
===========================================
  Files          184      202      +18     
  Lines        10767    12263    +1496     
  Branches       835      991     +156     
===========================================
+ Hits         10571    12063    +1492     
+ Misses         186      170      -16     
- Partials        10       30      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@git-init-priyanshu
Copy link
Member Author

Hey @SiddheshKukade @JamaicanFriedChicken, Can you please review my PR.

Copy link
Member

@SiddheshKukade SiddheshKukade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

@palisadoes palisadoes merged commit ad3e16e into PalisadoesFoundation:develop Jan 16, 2024
8 of 9 checks passed
@palisadoes palisadoes mentioned this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants