-
-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test file for updatePluginStatus.ts #1682
Test file for updatePluginStatus.ts #1682
Conversation
This reverts commit 1ac5f89.
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1682 +/- ##
===========================================
+ Coverage 98.17% 98.36% +0.18%
===========================================
Files 184 202 +18
Lines 10767 12263 +1496
Branches 835 991 +156
===========================================
+ Hits 10571 12063 +1492
+ Misses 186 170 -16
- Partials 10 30 +20 ☔ View full report in Codecov by Sentry. |
Hey @SiddheshKukade @JamaicanFriedChicken, Can you please review my PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine
ad3e16e
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
Tests
Issue Number:
Fixes #1681
Did you add tests for your changes?
Yes
Snapshot
s/Videos:
If relevant, did you update the documentation?
No
Summary
Added tests for updatePluginStatus.ts file
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes