Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] : npm run setup bug #714

Merged
merged 5 commits into from
Jun 8, 2022

Conversation

SiddheshKukade
Copy link
Member

What kind of change does this PR introduce?

bugfix

Issue Number:

Fixes #712

Did you add tests for your changes?
NO
Snapshots/Videos:

image

If relevant, did you update the documentation?

Summary
Just renamed a file which was causing the error.

Does this PR introduce a breaking change?
No

Other information
Not needed

Have you read the contributing guide?
Yes

@SiddheshKukade SiddheshKukade changed the title Aboutmd bug [Bug Fix] : npm run setup bug Jun 8, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #714 (0aabc1d) into develop (db42d7f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #714   +/-   ##
========================================
  Coverage    46.65%   46.65%           
========================================
  Files          136      136           
  Lines         2602     2602           
  Branches       649      649           
========================================
  Hits          1214     1214           
+ Misses        1127     1126    -1     
- Partials       261      262    +1     
Impacted Files Coverage Δ
...resolvers/language_maintainer_query/getlanguage.js 70.00% <0.00%> (-30.00%) ⬇️
...ib/resolvers/group_chat_query/groupChatMessages.js 100.00% <0.00%> (+100.00%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@palisadoes
Copy link
Contributor

Siddhesh why did you include the test file in this PR? It's not related.

@SiddheshKukade
Copy link
Member Author

Siddhesh why did you include the test file in this PR? It's not related.

Sorry sir . I forgot to remove it from the staging area

Copy link
Contributor

@JamaicanFriedChicken JamaicanFriedChicken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@palisadoes palisadoes merged commit 08433d8 into PalisadoesFoundation:develop Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report : npm run setup compiles with error
4 participants