Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final tenancy modifications #767

Merged
merged 14 commits into from
Oct 11, 2022
Merged

Final tenancy modifications #767

merged 14 commits into from
Oct 11, 2022

Conversation

ebrahim354
Copy link
Contributor

What kind of change does this PR introduce?
resolver modifications for the multi-tenancy project of GSoC 2022

Did you add tests for your changes?
yes

Summary
modified all relevant resolvers to match the new multi tenant changes.

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2022

Codecov Report

Merging #767 (3fbba7d) into talawa-api-multitenancy (e5a9676) will increase coverage by 0.12%.
The diff coverage is 67.37%.

@@                     Coverage Diff                     @@
##           talawa-api-multitenancy     #767      +/-   ##
===========================================================
+ Coverage                    65.57%   65.70%   +0.12%     
===========================================================
  Files                          181      184       +3     
  Lines                         3024     3353     +329     
  Branches                       702      713      +11     
===========================================================
+ Hits                          1983     2203     +220     
- Misses                         797      906     +109     
  Partials                       244      244              
Impacted Files Coverage Δ
lib/models/User.js 100.00% <ø> (ø)
lib/resolvers/GroupChatMessage.js 0.00% <0.00%> (ø)
...rs/group_chat_mutations/removeUserFromGroupChat.js 28.57% <14.28%> (-6.73%) ⬇️
.../resolvers/group_chat_mutations/removeGroupChat.js 35.29% <16.66%> (-11.38%) ⬇️
lib/resolvers/post_mutations/likeComment.js 30.00% <16.66%> (-7.50%) ⬇️
lib/resolvers/post_mutations/likePost.js 30.00% <16.66%> (-7.50%) ⬇️
lib/resolvers/post_mutations/unlikeComment.js 30.00% <16.66%> (-7.50%) ⬇️
lib/resolvers/post_mutations/unlikePost.js 30.00% <16.66%> (-7.50%) ⬇️
lib/resolvers/project_task_mutations/removeTask.js 30.00% <16.66%> (-8.89%) ⬇️
lib/resolvers/direct_chat_query/directChats.js 25.00% <18.18%> (-41.67%) ⬇️
... and 65 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@JamaicanFriedChicken JamaicanFriedChicken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @ebrahim354, you need to remove the console logs then i'll approve~

@JamaicanFriedChicken JamaicanFriedChicken merged commit a65fd0a into PalisadoesFoundation:talawa-api-multitenancy Oct 11, 2022
@ebrahim354 ebrahim354 deleted the final-tenancy-modifications branch October 25, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants