-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSOC]Docs : Plugin Architecture Overview Page #254
[GSOC]Docs : Plugin Architecture Overview Page #254
Conversation
I Would like to have Initial review from mentors for suggestions |
Looks good so far. You need to add more details in the different sections specifically the Talawa API section. Also, it's good you provided actual examples but you also should write about how someone could integrate their code as a plugin. For example, if we wanted to refactor the spam filter as a plugin what would be needed? What is the process of refactoring it? |
Thank you @DMills27 Sir for the review! Actually, I've created this page just for the introduction of the What do you think about this approach? |
@DMills27 Sir, I've also updated the first comment with the screenshots and the pull request is now ready to be reviewed. Plugin.Architecture.Demo.-.Installation.of.Plugin.from.store.mp4Please suggest improvements, thanks 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new changes have provided easy to follow instructions and a clear overview. The video that you also added in the PR is not entirely clear at the moment but that can be fixed later on.
This Pull Request is associated with Google Summer of Code 2022 Project link
What kind of change does this PR introduce?
Docs : Plugin Architecture Overview Page
Issue Number:
Fixes #251
Did you add tests for your changes?
Not required
Snapshots/Videos:
Will be added soon
If relevant, did you update the documentation?
Yes
Summary
Added
Overview of What a plugin actually means in talawa repositories
A High-level diagram to describe workflow with description
code explanation
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes
OUTPUT :