Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preventing to send form onClick left/right arrows in SchemaTabs compo… #796

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

stakoov
Copy link
Contributor

@stakoov stakoov commented Apr 8, 2024

…nent

Description

Add event.preventDefault() in SchemaTabs

Motivation and Context

Currently when we have arrows in code examples onClick event triggers the form.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@sserrata sserrata requested a review from blindaa121 April 8, 2024 20:04
@sserrata sserrata added bug Something isn't working and removed bug Something isn't working labels Apr 8, 2024
Copy link

github-actions bot commented Apr 8, 2024

Visit the preview URL for this PR (updated for commit 574fcf2):

https://docusaurus-openapi-36b86--pr796-7fqiqhj0.web.app

(expires Wed, 08 May 2024 20:39:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@blindaa121 blindaa121 merged commit d2ff97b into PaloAltoNetworks:main Apr 10, 2024
13 checks passed
@sserrata
Copy link
Member

sserrata commented Apr 10, 2024

@blindaa121 was this change ported to v3?

@stakoov stakoov deleted the fix-shemeTabs-component branch April 11, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants