Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect clientType and clientVersion defined in create_query() method #149

Closed
sserrata opened this issue Apr 2, 2020 · 0 comments · Fixed by #150
Closed

Incorrect clientType and clientVersion defined in create_query() method #149

sserrata opened this issue Apr 2, 2020 · 0 comments · Fixed by #150
Labels
bug Something isn't working

Comments

@sserrata
Copy link
Member

sserrata commented Apr 2, 2020

Describe the bug

The create_query() method statically defines the wrong clientType and clientVersion values. Note that these values differ from the UserAgent values added to the HTTPClient headers.

Expected behavior

These values should represent both the actual name of the library/SDK as well as the current version.

Current behavior

See description.

Possible solution

  • Change the clientType value to "cortex-data-lake-python"
  • Change the clientVersion value to be the library __version__

Steps to reproduce

Screenshots

Context

Your Environment

  • Version used: alpha8
  • Environment name and version (e.g. Chrome 59, node.js 5.4, python 3.7.3):
  • Operating System and version (desktop or mobile):
  • Link to your project:
@sserrata sserrata added the bug Something isn't working label Apr 2, 2020
sserrata added a commit to sserrata/pan-cortex-data-lake-python that referenced this issue Apr 3, 2020
@sserrata
Update clientType and clientVersion, fixes PaloAltoNetworks#149
89c94d5
@sserrata sserrata mentioned this issue Apr 3, 2020
Merged
4 tasks
sserrata added a commit that referenced this issue Apr 3, 2020
@sserrata
Alpha9 (#150)
d3709b3 
* Update clientType and clientVersion, fixes #149

* Reduce number of times json() property is called, fixes #148

* Check if static access_token exists before developer token refresh, fixes #147

* Bump version to alpha9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Alpha9 sserrata/pan-cortex-data-lake-python
1 participant
@sserrata