优化：顶部标签栏缓存数组，删除元素函数

PanJiaChen · Oct 6, 2019 · 8365d9b · 8365d9b
1 parent e3cbf4a
commit 8365d9b
Showing 1 changed file with 4 additions and 14 deletions.
diff --git a/src/store/modules/tagsView.js b/src/store/modules/tagsView.js
@@ -28,13 +28,8 @@ const mutations = {
     }
   },
   DEL_CACHED_VIEW: (state, view) => {
-    for (const i of state.cachedViews) {
-      if (i === view.name) {
-        const index = state.cachedViews.indexOf(i)
-        state.cachedViews.splice(index, 1)
-        break
-      }
-    }
+    const index = state.cachedViews.indexOf(view.name)
+    index > -1 && state.cachedViews.splice(index, 1)
   },
 
   DEL_OTHERS_VISITED_VIEWS: (state, view) => {
@@ -43,13 +38,8 @@ const mutations = {
     })
   },
   DEL_OTHERS_CACHED_VIEWS: (state, view) => {
-    for (const i of state.cachedViews) {
-      if (i === view.name) {
-        const index = state.cachedViews.indexOf(i)
-        state.cachedViews = state.cachedViews.slice(index, index + 1)
-        break
-      }
-    }
+    const index = state.cachedViews.indexOf(view.name)
+    index > -1 && (state.cachedViews = state.cachedViews.slice(index, index + 1))
   },
 
   DEL_ALL_VISITED_VIEWS: state => {