Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove inject icons #571

Merged
merged 3 commits into from
Feb 9, 2023
Merged

fix: remove inject icons #571

merged 3 commits into from
Feb 9, 2023

Conversation

vozbrann
Copy link
Contributor

@vozbrann vozbrann commented Feb 7, 2023

No description provided.

@lazzystep
Copy link
Contributor

Looks good to me✔️
Further steps: create migration guide with common issues during upgrade

@vozbrann vozbrann marked this pull request as ready for review February 8, 2023 16:41
loader: 'svg-sprite-loader',
test: /\.svg$/i,
issuer: /\.[jt]sx?$/,
use: ['@svgr/webpack'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-02-09 at 11 58 51

@vozbrann could check if it can be helpful for us?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really in our case. Will require types refactoring.
The only usage of imported icon:
image

@vozbrann vozbrann merged commit b86cb63 into master Feb 9, 2023
@vozbrann vozbrann deleted the fix/remove-inject-icons branch February 9, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon All icons are injected in <body> (in prod) Investigate Icon Component Remove svg-sprite
3 participants