feat!: day-picker empty value #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazzystep
reviewed
Feb 8, 2023
|
|
||
| const [isCalendarOpen, setIsCalendarOpen] = useState(false); | ||
| const [date, setDate] = useState<Date>(defaultDate); | ||
| const [dateTime, setDateTime] = useState(transformTime(new Date(date))); | ||
| const [date, setDate] = useState<Date | null>(defaultDate); |
There was a problem hiding this comment.
do we really need date and dateTime?
I feel like it's a bit redundant, single date transformation would be better.
There was a problem hiding this comment.
@lazzystep
The component is deprecated. Hopefully, it's the last change to it. The logic inside is hard to customize and maintain, so the suggestion is to leave it like it is
lazzystep
approved these changes
Feb 8, 2023
vlacher12
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.