Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impact with terrain after adjusting vessel height #29

Closed
KSAMissionCtrl opened this issue Feb 7, 2017 · 2 comments
Closed

Impact with terrain after adjusting vessel height #29

KSAMissionCtrl opened this issue Feb 7, 2017 · 2 comments
Assignees
Labels

Comments

@KSAMissionCtrl
Copy link

Thanks for implementing the ability to change the height of the vessel! It doesn't seem to snap properly back to the default settings when you tab through them however, and if you made it lower than normal when it drops to the very fine setting it will try to go through the ground. BOOM! :P

@gomker gomker self-assigned this May 16, 2017
@gomker gomker added the bug label May 16, 2017
@PapaJoesSoup PapaJoesSoup assigned PapaJoesSoup and unassigned gomker May 14, 2018
@PapaJoesSoup
Copy link
Owner

Behavior of the movement mode switch (Tab key) does not result in intuitive behavior. The existing code tries to account for the fact that the user is changing the mode and sets the altitude, but if changes are made to the altitude, these are factored in and can result in vessels going underground.

It seems to me that a separate means to account for altitude changes while allowing mode changes is needed. If a user has not altered the altitude, and desires to change the mode, then the altitude can be set to a preset level (as is the current behavior). However, when the altitude has been changed then the mode changes need to respect the current altitude and not alter it. This would allow precise control over the final altitude set by the user.

With that said, a need for detecting when a user wants to "reset" the mode to its default settings is needed. I suggest adding a key that will allow resetting the altitude to default settings.

@PapaJoesSoup
Copy link
Owner

Fix in place. code now detects when over water or land. Prevents placing craft below the surface unless in water. Mode changes no longer position craft underground. Additionally, changes made to make altitude changes more intuitive, and if changing altitude manually, movement mode changes no longer change the current altitude of the craft. Added a reset button (Throttle Cuttoff) to reset this behavior back to default.

Will be released with version 1.7.3

PapaJoesSoup pushed a commit that referenced this issue May 14, 2018
 - Add Crew selection screen to spawn feature.  You can now (optionally) select one crewmember from a list of available crew. Git Issue #17
 - Fixed Tab key movement mode changes to prevent positioning craft underground. Git Issue #29
 - Clean up tool tips to display above window and not beyond edge of screen.
 - Improved control of altitude during movement mode changes. Now when changing altitudes, changes to movement mode will not alter current altitude.
 - Added new Movement Mode altitude reset key Throttle Cuttoff (Default is X) to allow for flexible altitude positioning.
 - Revised help and readme to reflect changes to hot keys.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants