Run round-trip adventure codec tests with JSON, NBT, and Java ops. Use JavaOps for conversions. #10031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should probably put that test util stuff into the test changes patch |
MiniDigger
reviewed
Dec 21, 2023
Machine-Maker
approved these changes
Dec 21, 2023
…e JavaOps for conversions.
Owen1212055
approved these changes
Feb 17, 2024
lynxplay
pushed a commit
to lynxplay/paper
that referenced
this pull request
Feb 23, 2024
…e JavaOps for conversions. (PaperMC#10031)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure whether we care to split the test additions and switch over to using JavaOps for conversions into separate PRs. For now, they are both in this one.