Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly read and store sus effect duration #10050

Merged

Conversation

Machine-Maker
Copy link
Member

@Machine-Maker Machine-Maker commented Dec 19, 2023

Fixes #10049

The default effect duration is 160, and if it is 160, vanilla does not store it in the NBT, but itemmeta doesn't know this so it gets changed to 0 when read and applied.


Download the paperclip jar for this pull request: paper-10050.zip

@Machine-Maker Machine-Maker added the build-pr-jar Enables a workflow to build Paperclip jars on the pull request. label Dec 19, 2023
@Machine-Maker Machine-Maker requested a review from a team as a code owner December 19, 2023 04:06
@Machine-Maker Machine-Maker force-pushed the fix/suspicious-stew-duration branch from 2bd7611 to 68f38a5 Compare December 19, 2023 20:34
@Machine-Maker Machine-Maker merged commit 8c007d9 into PaperMC:master Dec 19, 2023
1 check passed
@Machine-Maker Machine-Maker deleted the fix/suspicious-stew-duration branch December 19, 2023 21:31
lynxplay pushed a commit to lynxplay/paper that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-pr-jar Enables a workflow to build Paperclip jars on the pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Effects (Blindness and Darness) are not granted and are immediately removed
3 participants