Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix update future return type #8120

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Fix update future return type #8120

merged 1 commit into from
Jul 19, 2022

Conversation

Machine-Maker
Copy link
Member

Paper's PlayerProfile interface has an update() method that returns a CompletableFuture<bukkit.PlayerProfile> when it should be a CompletableFuture<paper.PlayerProfile.

You should be able to change the return generic param to include ? extends bukkit.PlayerProfile without breaking ABI.

@Machine-Maker Machine-Maker requested a review from a team as a code owner July 10, 2022 19:04
@Machine-Maker Machine-Maker merged commit b7faa65 into PaperMC:master Jul 19, 2022
@Machine-Maker Machine-Maker deleted the fix/player-profile branch July 19, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytv kennytv kennytv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Machine-Maker @kennytv