fix #8138 #8139
Merged
fix #8138 #8139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electronicboy
approved these changes
Jul 13, 2022
|
(very quiet: port to 1.18.2 please) |
|
That will not be necessary, as this bug only affected 1.19 Paper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent update to the Eigencraft patch introduced a bug that saw indirect shape updates omitted entirely, which can leave newly placed wire blocks in an invalid state (not updating their connections). This PR re-introduces those indirect shape updates to fix that issue. This does result in a slight performance penalty (or rather, it undoes the performance gain from the recent update).