Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #8146 #8148

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Fix #8146 #8148

merged 2 commits into from
Jul 18, 2022

Conversation

SpaceWalkerRS
Copy link
Contributor

No description provided.

@SpaceWalkerRS SpaceWalkerRS requested a review from a team as a code owner July 16, 2022 18:31
kennytv
kennytv requested changes Jul 18, 2022
View reviewed changes
Copy link
Member

@kennytv kennytv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem quite right, now the event is fired twice on the location it wasn't fired previously

@SpaceWalkerRS
Copy link
Contributor Author

Doesn't seem quite right, now the event is fired twice on the location it wasn't fired previously

I accidentally made so the event was fired even if the power level didn't change. That is now fixed!

kennytv
kennytv approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@kennytv kennytv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, thank you!

@kennytv kennytv merged commit 384d639 into PaperMC:master Jul 18, 2022
@D-VR D-VR mentioned this pull request Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytv kennytv kennytv approved these changes

@SpiritOTHawk SpiritOTHawk SpiritOTHawk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SpaceWalkerRS @kennytv @SpiritOTHawk