Deprecate public Timings classes for removal #8949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olijeffers0n
approved these changes
Mar 7, 2023
|
I fully understand why you guys are removing timings, but as mentioned please bring in spark to replace it so we have something to use for timings. |
|
Replacing timings with spark is the idea yeah, see the issue linked in the pr description. |
|
LGTM |
|
I am EterNity and I approve this message. |
kashike
approved these changes
Mar 28, 2023
Sorry! Didn't see that part, forgot my glasses! 🧐😅 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step of #8948, assuming we actually decide to remove timings entirely.
After an explicit announcement and some more time passes, we can also add runtime warnings.