Use ? super in Consumer/Predicate API #9939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Machine-Maker
force-pushed
the
fix/use-super
branch
from
5b0e205 to
fe2c53a
Compare
Machine-Maker
force-pushed
the
fix/use-super
branch
from
fe2c53a to
f193cee
Compare
electronicboy
approved these changes
Nov 14, 2023
Machine-Maker
force-pushed
the
fix/use-super
branch
2 times, most recently
from
0d7e2c0 to
8d0b234
Compare
Machine-Maker
force-pushed
the
fix/use-super
branch
from
8d0b234 to
5fc89c7
Compare
Owen1212055
approved these changes
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also reformats any patches that had incorrect Consumer and Predicate params to follow a better codestyle. Eventually we are going to want to do this to the whole API, when we have upstream in source in repo, but for API that we add, we want it to be a part of the patch so we don't clutter up the git history any more than needed.