Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for providing download from a CDN instead of local storage #99

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kashike
Copy link
Member

@kashike kashike commented May 28, 2022

No description provided.

@MiniDigger
Copy link
Member

looks good, only thing I have is that we could consider caching CDN jars locally, but idk how billing for the cdn here works
(would need to reverse the order then, locally first then cdn)

Copy link
Member

@MiniDigger MiniDigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, lgtm

need to think what we set as remote url, might wanna put the b2 bucket behind cf

@kashike kashike added the type: enhancement New feature or request label Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants