Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[perf,refactor,style]: performance improvements and large-scale code cleanup #55

Merged
merged 32 commits into from
Jan 31, 2024
Merged

[perf,refactor,style]: performance improvements and large-scale code cleanup #55

merged 32 commits into from
Jan 31, 2024

Conversation

null8626
Copy link
Member

@null8626 null8626 commented Jan 31, 2024 •
edited
Loading

the following pull request lessens the codebase's reliance on .clone(), .to_string(), .to_owned(), etc. (in particular the SelectItem struct, IndexMap struct usage, and several other enum properties)

other than that, i also made the code slightly squeeky cleaner :)

null8626 added 30 commits January 31, 2024 18:00
@null8626
[perf,refactor]: cleanups and serde performance improvements
896ccbb
@null8626
fix: hopefully fix some errors
fcb8831
@null8626
fix: bomb struct
bbfcbc1
@null8626
fix: apparently i was dumb
124462f
@null8626
[fix,perf]: consume self
e43758b
@null8626
[fix,revert]: fix ownership errors (i hope)
09220c0
@null8626
fix: make clippy happy
e758c38
@null8626
perf: lessen .clone() usage
4efa123
@null8626
fix: remove ref argument
6882f38
@null8626
perf: lesser use of to_owned and String::from
7fa5507
@null8626
revert: oops ok fine
376d6a1
@null8626
fix: use Cows
9e8424d
@null8626
let's see if this hack works
518ad1f
@null8626
perf: use
1cf49c5
@null8626
fix: force static str here too
e6aee63
@null8626
fix: consume too
c259bfe
@null8626
fix: update with_headers too
44954e1
@null8626
perf: do the same to SelectItem too
636f46a
@null8626
fix: fix import errors
6c4012b
@null8626
fix: fix type errors
92f14b4
@null8626
fix: use cow
9ebe1ae
@null8626
[fix,perf]: even more str slices!
d7e9e32
@null8626
refactor: even more cleanups...
1fbad98
@null8626
fix: fix iterator errors
e849de9
@null8626
fix: fix extend issues
1e26265
@null8626
style: cleaner imports for readability
1f66668
@null8626
fix: oops forgot there is a conflict
82a4c51
@null8626
revert: oops didnt know those two are different..
cb00bd3
@null8626
fix: CARGO PLEASE HAVE MERCY ON ME
824b489
@null8626
fix: make clippy happy
33cc492
@TheAlan404
Copy link
Contributor

LGTM 👍

@TheAlan404 TheAlan404 merged commit 944771c into ParadigmMC:main Jan 31, 2024
@null8626 null8626 mentioned this pull request Feb 1, 2024
Merged
null8626 added a commit that referenced this pull request Feb 1, 2024
@null8626
refactor: several more cleanups from #55 (#56)
f7e6145 
* perf: make IndexMap key Cow str

* fix: i forgot some stuff

* fix: stringify

* fix: use enum argument

* fix: use lt gt operators

* fix: make clippy happy

* fix: this should be or
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@null8626 @TheAlan404