Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev team chat #26669

Merged
merged 9 commits into from
Sep 3, 2024
Merged

Dev team chat #26669

merged 9 commits into from
Sep 3, 2024

Conversation

S34NW
Copy link
Member

@S34NW S34NW commented Sep 2, 2024 •
edited
Loading

What Does This PR Do

Adds an ingame chat for dev team members to communicate with each other and admins.
Adds a dev team permission to access this chat.
Refactors who code to be less insane, adds a dev section to it.

Why It's Good For The Game

Better cross-team and inter-team communications is good.

Images of changes

delwedd
delwedd

delwedd

Testing

Tried to speak as admin, dev member, and non-admin. Everything worked as intended.

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
add: Added developer team chat
/:cl:

@S34NW S34NW requested a review from AffectedArc07 as a code owner September 2, 2024 08:06
@S34NW S34NW added Feature This PR is a new addition to the game Administration This PR relates to ingame administration features labels Sep 2, 2024
AffectedArc07
AffectedArc07 reviewed Sep 2, 2024
View reviewed changes
Copy link
Member

@AffectedArc07 AffectedArc07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought a fair bit on this, is it worth just converting +VIEWRUNTIMES into +DEV?

Trying to think of an instance where we need +RUNTIMES but not access to a private chat to discuss current TM.

code/modules/admin/verbs/adminsay.dm Show resolved Hide resolved
code/modules/admin/verbs/adminsay.dm Outdated Show resolved Hide resolved
config/example/config.toml Outdated Show resolved Hide resolved
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Configuration Change This PR changes the game configuration files. Please run via the host. TGUI This PR modifies TGUI, will conflict labels Sep 2, 2024
@ROdenFL
Copy link
Contributor

ROdenFL commented Sep 2, 2024

kinda funny. two weeks ago made almost similiar thing ss220-space/Paradise#5765

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Sep 2, 2024
Burzah
Burzah reviewed Sep 2, 2024
View reviewed changes
config/example/config.toml Outdated Show resolved Hide resolved
AffectedArc07
AffectedArc07 reviewed Sep 2, 2024
View reviewed changes
Copy link
Member

@AffectedArc07 AffectedArc07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you if you want to change .Add() to +=.

Im fine to merge this as is

S34NW and others added 2 commits September 3, 2024 13:47
@S34NW @ROdenFL
Update code/__DEFINES/admin_defines.dm
dbda515 
Co-authored-by: ROdenFL <ROdenFL@yandex.ru>
Signed-off-by:  Sean <12197162+S34NW@users.noreply.github.com>
@S34NW
.Add to +=
3460b02
AffectedArc07
AffectedArc07 approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@AffectedArc07 AffectedArc07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready after that one config nit

@S34NW @AffectedArc07
Update config/example/config.toml
f269b72 
Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
Signed-off-by:  Sean <12197162+S34NW@users.noreply.github.com>
@AffectedArc07 AffectedArc07 added this pull request to the merge queue Sep 3, 2024
Merged via the queue into ParadiseSS13:master with commit 73e861b Sep 3, 2024
11 checks passed
@lewcc lewcc mentioned this pull request Sep 3, 2024
Merged
1 task
@dageavtobusnick dageavtobusnick mentioned this pull request Jan 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ROdenFL ROdenFL ROdenFL left review comments

@Burzah Burzah Burzah left review comments

@Contrabang Contrabang Contrabang left review comments

@AffectedArc07 AffectedArc07 AffectedArc07 approved these changes

Assignees

@AffectedArc07 AffectedArc07

Labels
-Status: Awaiting review This PR is awaiting review from the review team Administration This PR relates to ingame administration features Configuration Change This PR changes the game configuration files. Please run via the host. Feature This PR is a new addition to the game TGUI This PR modifies TGUI, will conflict
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@S34NW @ROdenFL @AffectedArc07 @Contrabang @Burzah @ParadiseSS13-Bot