Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates OD lints #26729

Merged
merged 7 commits into from
Sep 27, 2024
Merged

Updates OD lints #26729

merged 7 commits into from
Sep 27, 2024

Conversation

Contrabang
Copy link
Contributor

@Contrabang Contrabang commented Sep 9, 2024

What Does This PR Do

Cotinues #24516. Updates OD lints. More info to come soon.
Fixes #26727

This updates OD to have a few new errors, notably

  • InvalidIndexOperation
  • AmbiguousInOrder

This PR fixes all issues of those pragmas.

This PR also adds disabled pragmas to the file, like

  • Typemaker Pragmas
  • PickWeightedSyntax (lots of errors from this, so it was excluded).

Why It's Good For The Game

OD lints help us catch nasty code

Testing

Paper bundles work, pathfinding worked


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

NPFC

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Sep 9, 2024
@BiancaWilkson BiancaWilkson added the Infrastructure This PR will update GitHub tooling label Sep 9, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Sep 11, 2024
@Contrabang Contrabang marked this pull request as ready for review September 19, 2024 00:29
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Sep 19, 2024
@AffectedArc07 AffectedArc07 added this pull request to the merge queue Sep 27, 2024
Merged via the queue into ParadiseSS13:master with commit 900271a Sep 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Infrastructure This PR will update GitHub tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenDream-detected in logic errors
6 participants