Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Disable "Light Exposure" Alert when inside locker for Shadowpeople #26837

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

leoworm
Copy link
Contributor

@leoworm leoworm commented Sep 19, 2024

What Does This PR Do

When a Shadowperson enters into a locker, it is treated as if they were in darkness. They are healed, and the "Light Exposure" alert is removed.

Fixes #26833

Why It's Good For The Game

Shadowpeople already have it hard enough. Stops them from being confused due to an inaccuate alert.

Testing

  • Turned myself into a shadowperson, burnt myself, then hid in locker to verify that the alert vanishes and I heal

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

  • Added case for when in a locker

@ParadiseSS13-Bot ParadiseSS13-Bot added the On Hold Its gonna be a while before this is reviewed label Sep 19, 2024
@ParadiseSS13-Bot
Copy link
Contributor

Your PR has been put on hold as your GitHub account is not linked to a Paradise forums account.

Please link your account at https://www.paradisestation.org/forum/custom/link_github_account.php

Headcoders may ignore this in specific circumstances (Minor fix PR, trusted contributor from another codebase, anything at their discretion)

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Sep 19, 2024
@farie82 farie82 removed the On Hold Its gonna be a while before this is reviewed label Sep 22, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Sep 22, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Sep 26, 2024
@Burzah Burzah added this pull request to the merge queue Sep 28, 2024
Merged via the queue into ParadiseSS13:master with commit 0f58720 Sep 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting into a locker as a Shadowperson will not update the light notification correctly
5 participants