Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] Adds TG "busy" cogbar animation for players #27932

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

MiraHell
Copy link
Contributor

@MiraHell MiraHell commented Jan 10, 2025

What Does This PR Do

Ports a little cogbar indicator above a player when they're currently doing something. This indicator is only visible to other players. Some actions, such as breaking free, antagonist actions, and a few others are hidden. It also ports the vis_overlays subsystem needed for cogbars. Additionally, it introduces the PREFTOGGLE_3 variable, so need to inform AA if merged.
Changes made from the TG version:
Cogbar indicators are added as a user setting, defaulting to enabled. Disabling it will hide all cogbar indicators from you, but others will still see the indicator above you.

Why It's Good For The Game

This feature provides additional feedback that lets players know that someone is currently performing an action. The user setting is available for players who may find it distracting and wish for an experience closer to what they currently have.

Images of changes

Videos
Assistant.POV.mp4
Doctor.POV.mp4

Testing

I logged into the local server using my ckey and a guest account, built an airlock while observing it from another client, and then checked the hidden actions to confirm they were not displayed. After that, I disabled cogbars in preferences for one client, and they stopped displaying for him.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

image


Changelog

🆑
add: Added a new UI element that appears over players who are interacting, building, etc. This feature can be disabled in preferences.
/:cl:

original author: jlsnow301
tgstation/tgstation#82416

@lewcc lewcc added Configuration Change This PR changes the game configuration files. Please run via the host. SQL Change This PR modifies the game database. This PR must go through the host. Feature This PR is a new addition to the game and removed Configuration Change This PR changes the game configuration files. Please run via the host. labels Jan 10, 2025
code/__DEFINES/preferences_defines.dm Outdated Show resolved Hide resolved
code/__DEFINES/subsystems.dm Outdated Show resolved Hide resolved
Copy link
Contributor

@Christasmurf Christasmurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sprite changes LGTM

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally Sprites This PR modifies the game sprites -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Jan 11, 2025
@Destrucnope
Copy link

This is a great idea! It always is a bit awkward when you are just standing there but also cant move

code/_onclick/hud/plane_master.dm Outdated Show resolved Hide resolved
code/controllers/subsystem/SSvis_overlays.dm Outdated Show resolved Hide resolved
MiraHell and others added 2 commits January 30, 2025 11:14
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: Mira <42539014+MiraHell@users.noreply.github.com>
@lewcc
Copy link
Contributor

lewcc commented Jan 30, 2025

I'm curious to see the on-server profile info from this, due to all the new animates this'll invoke.

That being said, super excited to see this.

code/__HELPERS/mob_helpers.dm Outdated Show resolved Hide resolved
code/game/objects/structures/safe.dm Show resolved Hide resolved
MiraHell and others added 2 commits February 2, 2025 11:33
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: Mira <42539014+MiraHell@users.noreply.github.com>
Copy link
Member

@DGamerL DGamerL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending lewc rereview

@DGamerL DGamerL requested a review from lewcc February 4, 2025 15:10
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Feb 4, 2025
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Feb 12, 2025
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Feb 12, 2025
@MiraHell
Copy link
Contributor Author

CI failing doesn't seem related to the PR as it's failing on other PRs too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Feature This PR is a new addition to the game Sprites This PR modifies the game sprites SQL Change This PR modifies the game database. This PR must go through the host.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants