-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PORT] Adds TG "busy" cogbar animation for players #27932
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sprite changes LGTM
This is a great idea! It always is a bit awkward when you are just standing there but also cant move |
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com> Signed-off-by: Mira <42539014+MiraHell@users.noreply.github.com>
I'm curious to see the on-server profile info from this, due to all the new animates this'll invoke. That being said, super excited to see this. |
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com> Signed-off-by: Mira <42539014+MiraHell@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending lewc rereview
CI failing doesn't seem related to the PR as it's failing on other PRs too |
What Does This PR Do
Ports a little cogbar indicator above a player when they're currently doing something. This indicator is only visible to other players. Some actions, such as breaking free, antagonist actions, and a few others are hidden. It also ports the vis_overlays subsystem needed for cogbars. Additionally, it introduces the PREFTOGGLE_3 variable, so need to inform AA if merged.
Changes made from the TG version:
Cogbar indicators
are added as a user setting, defaulting to enabled. Disabling it will hide all cogbar indicators from you, but others will still see the indicator above you.Why It's Good For The Game
This feature provides additional feedback that lets players know that someone is currently performing an action. The user setting is available for players who may find it distracting and wish for an experience closer to what they currently have.
Images of changes
Videos
Assistant.POV.mp4
Doctor.POV.mp4
Testing
I logged into the local server using my ckey and a guest account, built an airlock while observing it from another client, and then checked the hidden actions to confirm they were not displayed. After that, I disabled cogbars in preferences for one client, and they stopped displaying for him.
Declaration
Changelog
🆑
add: Added a new UI element that appears over players who are interacting, building, etc. This feature can be disabled in preferences.
/:cl:
original author: jlsnow301
tgstation/tgstation#82416