-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PFT-1796] Add changes for the snx subgraph code and order #75
Conversation
@@ -73,67 +24,18 @@ export const fetchAllMarketsDataQuery = gql` | |||
export const fetchMarketByIdQuery = (marketId: string) => gql` | |||
{ | |||
market(id: "${marketId.toLowerCase()}") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we tested this? The market id in the latest snx subgraph is a number (even though IDs are stored as strings). Please check the subgraph.yaml and the returned data.
Also update the test cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Akhilleshgoswami Not sure if anything was changed here. Could you please explain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so I have only written test case for the order, positions, and account as we were using the market from the synthetix parifi SDK , I didn't change the code here
… snx-subgraph-code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamamitkumar0512 @Akhilleshgoswami Please work on the requested changes
@@ -190,3 +193,21 @@ export const fetchPositionIdsForOrderIds = (orderIds: string[]) => gql` | |||
} | |||
} | |||
`; | |||
|
|||
export const fectchCollateralForOrderUsingAccountId = (accountId: string | string[]) => gql` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
@@ -1,61 +1,12 @@ | |||
import { getParifiSdkInstanceForTesting } from '..'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Account => Wallet
SnxAccount is a different term. Please do not mix them up
No description provided.