PBID-91: Store third-party cookie support state in compound cookie and expire after ttl #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icflournoy
reviewed
Apr 23, 2021
There was a problem hiding this comment.
Similar to our previous stories in prebid can you branch off master again into a branch such as parrableIdSystem/PBID-91_thirdPartyCookieSupport and then update this PR to merge into that. The parrableIdSystem/ branch will be what we take upstream.
Example: #17
victorigualada
changed the base branch from
master
to
parrableIdSystem/PBID-91_thirdPartyCookieSupport
victorigualada
commented
Apr 28, 2021
icflournoy
reviewed
Apr 28, 2021
| logErrorStub.restore(); | ||
| }); | ||
|
|
||
| describe('when getting tpcSupport from XHR response', function () { |
There was a problem hiding this comment.
I think we need a parallel block
describe('when reading tpcSupport status from cookie');and it tests sending the tpc support to the backend, and then when the tpcUntil expires it should test suppressing the status from the cookie.
icflournoy
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.