Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBID-14: Support US Privacy Framework #7

Merged
merged 3 commits into from
May 1, 2020

Conversation

icflournoy
Copy link

@icflournoy icflournoy commented Apr 29, 2020

This PR uses the Prebid consentManagementUsp module to fetch the uspString data from the browser and pass it to Parrable as the standard us_privacy query parameter outlined in the USP spec.

@icflournoy icflournoy requested a review from ralejandre April 29, 2020 18:09
@icflournoy icflournoy self-assigned this Apr 29, 2020
@icflournoy icflournoy changed the base branch from parrableIdSystem/base to master April 29, 2020 18:15
@icflournoy icflournoy changed the base branch from master to parrableIdSystem/base April 29, 2020 18:15
@icflournoy
Copy link
Author

icflournoy commented Apr 29, 2020

$ time gulp test
[14:21:23] Using gulpfile ~/dev/Parrable/Prebid.js/gulpfile.js
[14:21:23] Starting 'test'...
[14:21:23] Starting 'clean'...
[14:21:23] Finished 'clean' after 32 ms
[14:21:23] Starting 'lint'...
[14:21:43] Finished 'lint' after 20 s
[14:21:43] Starting 'test'...
ℹ 「wdm」:
ℹ 「wdm」: Compiled successfully.

START:
ℹ 「wdm」: Compiling...
ℹ 「wdm」:
ℹ 「wdm」: Compiled successfully.
29 04 2020 14:22:15.104:INFO [karma-server]: Karma v4.4.1 server started at http://0.0.0.0:9876/
29 04 2020 14:22:15.104:INFO [launcher]: Launching browsers ChromeHeadless with concurrency 5
29 04 2020 14:22:15.136:INFO [launcher]: Starting browser ChromeHeadless
29 04 2020 14:22:15.558:INFO [HeadlessChrome 81.0.4044 (Linux 0.0.0)]: Connected on socket elOMGdMUn1RsAYrSAAAA with id 86166689

Finished in 5.044 secs / 3.078 secs @ 14:22:21 GMT-0400 (EDT)

SUMMARY:
✔ 5499 tests completed
ℹ 4 tests skipped
[14:22:21] Finished 'test' after 38 s
[14:22:21] Finished 'test' after 58 s

real	0m59.288s
user	1m4.677s
sys	0m1.546s

@icflournoy
Copy link
Author

$ time gulp test
[13:38:38] Using gulpfile ~/dev/Parrable/Prebid.js/gulpfile.js
[13:38:38] Starting 'test'...
[13:38:38] Starting 'clean'...
[13:38:38] Finished 'clean' after 46 ms
[13:38:38] Starting 'lint'...
[13:39:08] Finished 'lint' after 31 s
[13:39:08] Starting 'test'...
ℹ 「wdm」:
ℹ 「wdm」: Compiled successfully.

START:
ℹ 「wdm」: Compiling...
ℹ 「wdm」:
ℹ 「wdm」: Compiled successfully.
30 04 2020 13:39:57.848:INFO [karma-server]: Karma v4.4.1 server started at http://0.0.0.0:9876/
30 04 2020 13:39:57.849:INFO [launcher]: Launching browsers ChromeHeadless with concurrency 5
30 04 2020 13:39:57.895:INFO [launcher]: Starting browser ChromeHeadless
30 04 2020 13:39:58.519:INFO [HeadlessChrome 81.0.4044 (Linux 0.0.0)]: Connected on socket gAp2Xz3-qm8fNBOkAAAA with id 36354901

Finished in 6.226 secs / 3.642 secs @ 13:40:06 GMT-0400 (EDT)

SUMMARY:
✔ 5499 tests completed
ℹ 4 tests skipped
[13:40:06] Finished 'test' after 58 s
[13:40:06] Finished 'test' after 1.47 min

real	1m29.537s
user	1m36.560s
sys	0m2.113s

Copy link

@ralejandre ralejandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I understand the changes (thank you for the screen-shares).

@icflournoy icflournoy merged commit 82dba43 into parrableIdSystem/base May 1, 2020
@icflournoy icflournoy deleted the parrableIdSystem/us-privacy branch May 1, 2020 14:01
icflournoy pushed a commit that referenced this pull request Dec 18, 2020
* updates for first cut at bidder

* fix up height and width

* adds test spec

* remove hello_world from commit'

* updates to support native and fix issues found in initial review

* fix handling of new node in response for native vs banner

* updates to handle OpenRTB base

* updates to support RTB style calls

* updates to get back to parity

* updates to testing

* updates to test media type handling

* updates to handling testing

* updates to testing

* remove report file

* updates to fix up unit/spec tests

* updates to fix up unit/spec tests

* updates to fix up unit/spec tests

* updates to handling of gdpr

* Delete hello_world.html

* remove hellow-world-sample

* Pubwise 481 (#7)

* updates to support PubWise bid adapter, test cases and documentation

* updates to fix param tes

* Pubwise 481 (#8)

* fixes for unit testing

* remove unused variables and params

* Updates to Remove Unused Vars (#9)

* remove unused vars

* updates to fix up used and unsused params

* updates to fix up used and unsused params (#10)

* updates to fix up used and unsused params

* updates to remove usersync and add gvlid

* Pubwise 481 (#11)

* updates to remove usersync, add https, and add gvlid

* Update pubwiseBidAdapter.js

* updates to remove json, to remove options hit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants