Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dashboard not building for docker platform arm64/v8 #2534

Merged
merged 29 commits into from
Oct 7, 2024

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Mar 5, 2024

New Pull Request Checklist

Issue Description

Docker images will not build locally or remotely for arm64/v8.

Closes: #2501

Approach

Update dev dependency packages preventing image building for arm64/v8, specifically puppeteer version 18.0.5->22.6.1.

These changes allow for building locally. There's still an issue for building via the CI, #2534 (comment)

TODOs before merging

  • Ensure CI passes

Signed-off-by: Corey <coreyearleon@icloud.com>
Copy link

parse-github-assistant bot commented Mar 5, 2024

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

Copy link

uffizzi-cloud bot commented Mar 5, 2024

Uffizzi Ephemeral Environment deployment-47798

⌚ Updated Mar 05, 2024, 05:17 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2534

📄 View Application Logs etc.

What is Uffizzi? Learn more

@stephannielsen
Copy link

@cbaker6 is this closing this issue? #2501

Would be awesome!

@cbaker6
Copy link
Contributor Author

cbaker6 commented Apr 8, 2024

@stephannielsen this branch does address the issues for building for arm64/v8. If you build on apple silicon from this branch locally, it should work fine. Unfortunately, the buildx emulation cross build takes way too long which is why it's failing in the CI.

You can either build the respective branch locally or you can use my image (details in the README) https://hub.docker.com/r/netreconlab/parse-hipaa-dashboard

@mtrezza mtrezza closed this Apr 24, 2024
@mtrezza mtrezza reopened this Apr 24, 2024
Copy link

uffizzi-cloud bot commented Apr 24, 2024

Uffizzi Ephemeral Environment deployment-50796

⌚ Updated Apr 24, 2024, 19:27 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2534

📄 View Application Logs etc.

What is Uffizzi? Learn more

@cbaker6 cbaker6 changed the title ci: Release for docker platform arm64/v8 fix: Dashboard not building for docker platform arm64/v8 Apr 24, 2024
@mtrezza
Copy link
Member

mtrezza commented Oct 7, 2024

I have updated the workflow to run for arm64/v8, it should also build the docker image when this PR gets merged. The CI time increases significantly by ~25mins. We may temporarily disable the docker build for arm64/v8 in the ci workflow, assuming that if it builds for amd64, it will also build for arm64/v8 in the release workflow. This is a temp solution until linux arm64 runners become available in GitHub Actions, presumably by EOY 2024.

@mtrezza mtrezza merged commit 8c4a862 into parse-community:alpha Oct 7, 2024
10 checks passed
parseplatformorg pushed a commit that referenced this pull request Oct 7, 2024
# [6.0.0-alpha.16](6.0.0-alpha.15...6.0.0-alpha.16) (2024-10-07)

### Bug Fixes

* Dashboard not building for Docker platform arm64/v8 ([#2534](#2534)) ([8c4a862](8c4a862))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0-alpha.16

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Oct 7, 2024
parseplatformorg pushed a commit that referenced this pull request Oct 7, 2024
# [6.0.0-beta.2](6.0.0-beta.1...6.0.0-beta.2) (2024-10-07)

### Bug Fixes

* Crash after setting filter using context menu and opening filters panel ([#2579](#2579)) ([5a690eb](5a690eb))
* Dashboard not building for Docker platform arm64/v8 ([#2534](#2534)) ([8c4a862](8c4a862))
* Descriptive statistics for number cells in data browser not showing ([#2581](#2581)) ([e146b6f](e146b6f))
* Filter string is erased when changing filter condition ([#2586](#2586)) ([6fa2c8c](6fa2c8c))
* Internal classes `_User`, `_Role`, `_Installation` referenced with pointer don't appear in data browser filter dialog ([#2599](#2599)) ([8239cc8](8239cc8))

### Features

* Add Cloud Config change history to roll back to previous values ([#2554](#2554)) ([a784129](a784129))
* Add data panel to display object related data fetched via Cloud Function ([#2584](#2584)) ([914cc71](914cc71))
* Add optional restriction of script execution to certain object fields and values ([#2488](#2488)) ([8feac9b](8feac9b))
* Add relational filter conditions in data browser ([#2576](#2576)) ([aa5c68d](aa5c68d))
* Add support for Node 22 ([#2603](#2603)) ([3689106](3689106))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0-beta.2

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Oct 7, 2024
parseplatformorg pushed a commit that referenced this pull request Oct 7, 2024
# [6.0.0](5.4.0...6.0.0) (2024-10-07)

### Bug Fixes

* App metrics for user and installation counts show dash ([#2528](#2528)) ([850d7b3](850d7b3))
* Class Level Permissions dialog throws error `TypeError: ce.current is null` for newly created class ([#2549](#2549)) ([27ed692](27ed692))
* Config page fails to load ([#2531](#2531)) ([d721b7c](d721b7c))
* Crash after setting filter using context menu and opening filters panel ([#2579](#2579)) ([5a690eb](5a690eb))
* Dashboard crashes if Parse Server Cloud Function script returns object ([#2516](#2516)) ([5de08f8](5de08f8))
* Dashboard not building for Docker platform arm64/v8 ([#2534](#2534)) ([8c4a862](8c4a862))
* Dashboard scrolls when selecting row in data browser ([#2559](#2559)) ([2aa54a5](2aa54a5))
* Data browser redirects to wrong class when changing app ([#2526](#2526)) ([7713f54](7713f54))
* Deleting all code in the JS Console editor fills in the default code ([#2558](#2558)) ([4b830ba](4b830ba))
* Descriptive statistics for number cells in data browser not showing ([#2581](#2581)) ([e146b6f](e146b6f))
* Filter string is erased when changing filter condition ([#2586](#2586)) ([6fa2c8c](6fa2c8c))
* Internal classes `_User`, `_Role`, `_Installation` referenced with pointer don't appear in data browser filter dialog ([#2599](#2599)) ([8239cc8](8239cc8))
* Open pointer in new tab in data browser not working when mount path is not root ([#2527](#2527)) ([2f4081f](2f4081f))

### Features

* Add Cloud Config change history to roll back to previous values ([#2554](#2554)) ([a784129](a784129))
* Add data panel to display object related data fetched via Cloud Function ([#2584](#2584)) ([914cc71](914cc71))
* Add descriptive statistics for number cells in data browser ([#2529](#2529)) ([ead9ec4](ead9ec4))
* Add filter `starts with` in data browser for fields of type Pointer ([#2553](#2553)) ([0b94ab6](0b94ab6))
* Add Node 20 support; remove Node 14, 16 support ([#2532](#2532)) ([578a339](578a339))
* Add Node 20 support; remove Node 14, 16 support ([#2535](#2535)) ([5c90f2d](5c90f2d))
* Add optional restriction of script execution to certain object fields and values ([#2488](#2488)) ([8feac9b](8feac9b))
* Add relational filter conditions in data browser ([#2576](#2576)) ([aa5c68d](aa5c68d))
* Add support for Node 22 ([#2603](#2603)) ([3689106](3689106))
* Execute script for selected rows ([#2508](#2508)) ([5d9901e](5d9901e))
* Select rows in data browser by clicking and dragging mouse cursor over checkboxes ([#2548](#2548)) ([792ba9e](792ba9e))

### BREAKING CHANGES

* Removes support for Node 14 and 16 ([5c90f2d](5c90f2d))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Oct 7, 2024
beiguancyc pushed a commit to beiguancyc/parse-dashboard that referenced this pull request Oct 8, 2024
* source: (70 commits)
  chore(release): 6.0.0 [skip ci]
  empty
  chore(release): 6.0.0-beta.2 [skip ci]
  empty
  chore(release): 6.0.0-alpha.16 [skip ci]
  fix: Dashboard not building for Docker platform arm64/v8 (parse-community#2534)
  refactor: Security upgrade node from 20.14.0-alpine3.20 to 20.17.0-alpine3.20 (parse-community#2593)
  chore(release): 6.0.0-alpha.15 [skip ci]
  feat: Add support for Node 22 (parse-community#2603)
  docs: Add info panel docs to README (parse-community#2601)
  chore(release): 6.0.0-alpha.14 [skip ci]
  feat: Add data panel to display object related data fetched via Cloud Function (parse-community#2584)
  chore(release): 6.0.0-alpha.13 [skip ci]
  fix: Internal classes `_User`, `_Role`, `_Installation` referenced with pointer don't appear in data browser filter dialog (parse-community#2599)
  refactor: Bump qs from 6.5.2 to 6.13.0 (parse-community#2595)
  refactor: Fix for 4 vulnerabilities (parse-community#2594)
  refactor: Bump webpack from 5.75.0 to 5.94.0 (parse-community#2588)
  chore(release): 6.0.0-alpha.12 [skip ci]
  fix: Filter string is erased when changing filter condition (parse-community#2586)
  refactor: Bump requirejs from 2.3.6 to 2.3.7 (parse-community#2582)
  ...

# Conflicts:
#	package-lock.json
@cbaker6 cbaker6 deleted the patch-1 branch October 21, 2024 06:28
vardhan0604 pushed a commit to vardhan0604/parse-dashboard that referenced this pull request Oct 22, 2024
vardhan0604 pushed a commit to vardhan0604/parse-dashboard that referenced this pull request Oct 22, 2024
# [6.0.0-alpha.16](parse-community/parse-dashboard@6.0.0-alpha.15...6.0.0-alpha.16) (2024-10-07)

### Bug Fixes

* Dashboard not building for Docker platform arm64/v8 ([parse-community#2534](parse-community#2534)) ([8c4a862](parse-community@8c4a862))
vardhan0604 pushed a commit to vardhan0604/parse-dashboard that referenced this pull request Oct 22, 2024
# [6.0.0-beta.2](parse-community/parse-dashboard@6.0.0-beta.1...6.0.0-beta.2) (2024-10-07)

### Bug Fixes

* Crash after setting filter using context menu and opening filters panel ([parse-community#2579](parse-community#2579)) ([5a690eb](parse-community@5a690eb))
* Dashboard not building for Docker platform arm64/v8 ([parse-community#2534](parse-community#2534)) ([8c4a862](parse-community@8c4a862))
* Descriptive statistics for number cells in data browser not showing ([parse-community#2581](parse-community#2581)) ([e146b6f](parse-community@e146b6f))
* Filter string is erased when changing filter condition ([parse-community#2586](parse-community#2586)) ([6fa2c8c](parse-community@6fa2c8c))
* Internal classes `_User`, `_Role`, `_Installation` referenced with pointer don't appear in data browser filter dialog ([parse-community#2599](parse-community#2599)) ([8239cc8](parse-community@8239cc8))

### Features

* Add Cloud Config change history to roll back to previous values ([parse-community#2554](parse-community#2554)) ([a784129](parse-community@a784129))
* Add data panel to display object related data fetched via Cloud Function ([parse-community#2584](parse-community#2584)) ([914cc71](parse-community@914cc71))
* Add optional restriction of script execution to certain object fields and values ([parse-community#2488](parse-community#2488)) ([8feac9b](parse-community@8feac9b))
* Add relational filter conditions in data browser ([parse-community#2576](parse-community#2576)) ([aa5c68d](parse-community@aa5c68d))
* Add support for Node 22 ([parse-community#2603](parse-community#2603)) ([3689106](parse-community@3689106))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Published docker image has no matching manifest for linux/arm64/v8
4 participants