feat: Add optional restriction of script execution to certain object fields and values #2488

dblythy · 2023-06-29T05:42:24Z

New Pull Request Checklist

I am not disclosing a vulnerability.
I am creating this PR in reference to an issue.

Issue Description

Currently, scripts show on all fields, and every single value.

Closes: #2487
Closes: #2485

Approach

Adds the following script syntax:

"scripts": [
    {
    "title": "Delete account",
    "classes": [
      {
        "name": "_User",
        "fields": [{ "name": "createdAt", "validator": "value => value > new Date(\"2025\")" }]
      }
    ],
    "cloudCodeFunction": "deleteAccount"
  }
]

If using this syntax, the script will only show on a field defined in fields, and it will be disabled if the validator returns false.

TODOs before merging

Add changes to documentation (guides, repository pages, in-code descriptions)

parse-github-assistant · 2023-06-29T05:42:26Z

I will reformat the title to use the proper commit message syntax.

parse-github-assistant · 2023-06-29T05:42:29Z

Thanks for opening this pull request!

🎉 We are excited about your hands-on contribution!

uffizzi-cloud · 2023-06-29T05:51:57Z

Uffizzi Ephemeral Environment `deployment-29709`

⌚ Updated Jun 29, 2023, 05:42 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2488

📄 View Application Logs etc.

What is Uffizzi? Learn more

mtrezza · 2023-06-29T11:18:46Z

Wow, impressive PR!

The two referenced issues are not necessarily related. One could enable a script only on fieldA if fieldB has a specific value. Would that be possible?

dblythy · 2023-06-30T03:31:05Z

Updated the syntax so the full Parse Object is passed through:

"validator": (row, field) => row.get(field) > new Date("2025")

mtrezza

Could you resolve the conflicts? I've merged the lint and prettier PR.

mtrezza

Could you also add a short example for this new feature to the README?

Signed-off-by: Daniel <daniel-blyth@live.com.au>

mtrezza · 2023-07-05T07:59:08Z

Btw could you see whether the prettier hook works for you? I've added husky to the repo, but not sure whether the git hook is actually working for existing clones of the repo.

dblythy · 2023-07-18T00:31:56Z

Didn't seem to run for me, perhaps my branch is outdated

mtrezza · 2023-07-18T00:56:49Z

Maybe hooks don't get committed? If I add a hook at least I don't see anything to commit. Anyway, was just a side node.

Parse-Dashboard/parse-dashboard-config.json

src/components/BrowserRow/BrowserRow.react.js

mtrezza

Could you please ament the README to document this feature?

README.md

mtrezza · 2023-08-27T22:44:52Z

@dblythy Could your take a look at the open questions? This seems almost ready to get merged.

uffizzi-cloud · 2024-02-29T13:42:22Z

Uffizzi Ephemeral Environment `deployment-47529`

⌚ Updated Feb 29, 2024, 13:39 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2488

📄 View Application Logs etc.

What is Uffizzi? Learn more

# [6.0.0-alpha.8](6.0.0-alpha.7...6.0.0-alpha.8) (2024-06-27) ### Features * Add optional restriction of script execution to certain object fields and values ([#2488](#2488)) ([8feac9b](8feac9b))

parseplatformorg · 2024-06-27T23:19:16Z

🎉 This change has been released in version 6.0.0-alpha.8

# [6.0.0-beta.2](6.0.0-beta.1...6.0.0-beta.2) (2024-10-07) ### Bug Fixes * Crash after setting filter using context menu and opening filters panel ([#2579](#2579)) ([5a690eb](5a690eb)) * Dashboard not building for Docker platform arm64/v8 ([#2534](#2534)) ([8c4a862](8c4a862)) * Descriptive statistics for number cells in data browser not showing ([#2581](#2581)) ([e146b6f](e146b6f)) * Filter string is erased when changing filter condition ([#2586](#2586)) ([6fa2c8c](6fa2c8c)) * Internal classes `_User`, `_Role`, `_Installation` referenced with pointer don't appear in data browser filter dialog ([#2599](#2599)) ([8239cc8](8239cc8)) ### Features * Add Cloud Config change history to roll back to previous values ([#2554](#2554)) ([a784129](a784129)) * Add data panel to display object related data fetched via Cloud Function ([#2584](#2584)) ([914cc71](914cc71)) * Add optional restriction of script execution to certain object fields and values ([#2488](#2488)) ([8feac9b](8feac9b)) * Add relational filter conditions in data browser ([#2576](#2576)) ([aa5c68d](aa5c68d)) * Add support for Node 22 ([#2603](#2603)) ([3689106](3689106))

parseplatformorg · 2024-10-07T13:45:32Z

🎉 This change has been released in version 6.0.0-beta.2

# [6.0.0](5.4.0...6.0.0) (2024-10-07) ### Bug Fixes * App metrics for user and installation counts show dash ([#2528](#2528)) ([850d7b3](850d7b3)) * Class Level Permissions dialog throws error `TypeError: ce.current is null` for newly created class ([#2549](#2549)) ([27ed692](27ed692)) * Config page fails to load ([#2531](#2531)) ([d721b7c](d721b7c)) * Crash after setting filter using context menu and opening filters panel ([#2579](#2579)) ([5a690eb](5a690eb)) * Dashboard crashes if Parse Server Cloud Function script returns object ([#2516](#2516)) ([5de08f8](5de08f8)) * Dashboard not building for Docker platform arm64/v8 ([#2534](#2534)) ([8c4a862](8c4a862)) * Dashboard scrolls when selecting row in data browser ([#2559](#2559)) ([2aa54a5](2aa54a5)) * Data browser redirects to wrong class when changing app ([#2526](#2526)) ([7713f54](7713f54)) * Deleting all code in the JS Console editor fills in the default code ([#2558](#2558)) ([4b830ba](4b830ba)) * Descriptive statistics for number cells in data browser not showing ([#2581](#2581)) ([e146b6f](e146b6f)) * Filter string is erased when changing filter condition ([#2586](#2586)) ([6fa2c8c](6fa2c8c)) * Internal classes `_User`, `_Role`, `_Installation` referenced with pointer don't appear in data browser filter dialog ([#2599](#2599)) ([8239cc8](8239cc8)) * Open pointer in new tab in data browser not working when mount path is not root ([#2527](#2527)) ([2f4081f](2f4081f)) ### Features * Add Cloud Config change history to roll back to previous values ([#2554](#2554)) ([a784129](a784129)) * Add data panel to display object related data fetched via Cloud Function ([#2584](#2584)) ([914cc71](914cc71)) * Add descriptive statistics for number cells in data browser ([#2529](#2529)) ([ead9ec4](ead9ec4)) * Add filter `starts with` in data browser for fields of type Pointer ([#2553](#2553)) ([0b94ab6](0b94ab6)) * Add Node 20 support; remove Node 14, 16 support ([#2532](#2532)) ([578a339](578a339)) * Add Node 20 support; remove Node 14, 16 support ([#2535](#2535)) ([5c90f2d](5c90f2d)) * Add optional restriction of script execution to certain object fields and values ([#2488](#2488)) ([8feac9b](8feac9b)) * Add relational filter conditions in data browser ([#2576](#2576)) ([aa5c68d](aa5c68d)) * Add support for Node 22 ([#2603](#2603)) ([3689106](3689106)) * Execute script for selected rows ([#2508](#2508)) ([5d9901e](5d9901e)) * Select rows in data browser by clicking and dragging mouse cursor over checkboxes ([#2548](#2548)) ([792ba9e](792ba9e)) ### BREAKING CHANGES * Removes support for Node 14 and 16 ([5c90f2d](5c90f2d))

parseplatformorg · 2024-10-07T13:53:42Z

🎉 This change has been released in version 6.0.0

# [6.0.0-beta.2](parse-community/parse-dashboard@6.0.0-beta.1...6.0.0-beta.2) (2024-10-07) ### Bug Fixes * Crash after setting filter using context menu and opening filters panel ([parse-community#2579](parse-community#2579)) ([5a690eb](parse-community@5a690eb)) * Dashboard not building for Docker platform arm64/v8 ([parse-community#2534](parse-community#2534)) ([8c4a862](parse-community@8c4a862)) * Descriptive statistics for number cells in data browser not showing ([parse-community#2581](parse-community#2581)) ([e146b6f](parse-community@e146b6f)) * Filter string is erased when changing filter condition ([parse-community#2586](parse-community#2586)) ([6fa2c8c](parse-community@6fa2c8c)) * Internal classes `_User`, `_Role`, `_Installation` referenced with pointer don't appear in data browser filter dialog ([parse-community#2599](parse-community#2599)) ([8239cc8](parse-community@8239cc8)) ### Features * Add Cloud Config change history to roll back to previous values ([parse-community#2554](parse-community#2554)) ([a784129](parse-community@a784129)) * Add data panel to display object related data fetched via Cloud Function ([parse-community#2584](parse-community#2584)) ([914cc71](parse-community@914cc71)) * Add optional restriction of script execution to certain object fields and values ([parse-community#2488](parse-community#2488)) ([8feac9b](parse-community@8feac9b)) * Add relational filter conditions in data browser ([parse-community#2576](parse-community#2576)) ([aa5c68d](parse-community@aa5c68d)) * Add support for Node 22 ([parse-community#2603](parse-community#2603)) ([3689106](parse-community@3689106))

feat: add ability to select script field

9fdd9a5

parse-github-assistant bot changed the title ~~feat: add ability to select script field~~ feat: Add ability to select script field Jun 29, 2023

dblythy requested a review from a team June 29, 2023 05:56

update syntax

af60334

Merge branch 'alpha' into create-script-row

4135d05

mtrezza reviewed Jul 4, 2023

View reviewed changes

Merge branch 'alpha' into create-script-row

9e2794c

Signed-off-by: Daniel <daniel-blyth@live.com.au>

mtrezza and others added 4 commits July 16, 2023 03:58

Merge branch 'alpha' into create-script-row

7f6d5f9

run lint

7149346

Update BrowserTable.react.js

e1c9da2

Update BrowserTable.react.js

0f5859e

mtrezza requested changes Jul 19, 2023

View reviewed changes

Parse-Dashboard/parse-dashboard-config.json Outdated Show resolved Hide resolved

src/components/BrowserRow/BrowserRow.react.js Outdated Show resolved Hide resolved

run lint and prettier

307a4ee

mtrezza requested changes Jul 20, 2023

View reviewed changes

Update README.md

bfd3b01

mtrezza reviewed Jul 21, 2023

View reviewed changes

README.md Show resolved Hide resolved

Merge branch 'alpha' into create-script-row

697de10

mtrezza closed this Feb 29, 2024

mtrezza reopened this Feb 29, 2024

Merge branch 'alpha' into create-script-row

a32d675

mtrezza closed this Jun 27, 2024

mtrezza reopened this Jun 27, 2024

mtrezza approved these changes Jun 27, 2024

View reviewed changes

mtrezza changed the title ~~feat: Add ability to select script field~~ feat: Add optional restriction of script execution to certain object fields and values Jun 27, 2024

mtrezza merged commit 8feac9b into parse-community:alpha Jun 27, 2024
16 checks passed

parseplatformorg added the state:released-alpha Released as alpha version label Jun 27, 2024

parseplatformorg added the state:released-beta Released as beta version label Oct 7, 2024

parseplatformorg added the state:released Released as stable version label Oct 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add optional restriction of script execution to certain object fields and values #2488

feat: Add optional restriction of script execution to certain object fields and values #2488

dblythy commented Jun 29, 2023

parse-github-assistant bot commented Jun 29, 2023

parse-github-assistant bot commented Jun 29, 2023 •

edited

Loading

uffizzi-cloud bot commented Jun 29, 2023

mtrezza commented Jun 29, 2023 •

edited

Loading

dblythy commented Jun 30, 2023 •

edited

Loading

mtrezza left a comment •

edited

Loading

mtrezza left a comment

mtrezza commented Jul 5, 2023 •

edited

Loading

dblythy commented Jul 18, 2023

mtrezza commented Jul 18, 2023

mtrezza left a comment

mtrezza commented Aug 27, 2023

uffizzi-cloud bot commented Feb 29, 2024

parseplatformorg commented Jun 27, 2024

parseplatformorg commented Oct 7, 2024

parseplatformorg commented Oct 7, 2024

feat: Add optional restriction of script execution to certain object fields and values #2488

feat: Add optional restriction of script execution to certain object fields and values #2488

Conversation

dblythy commented Jun 29, 2023

New Pull Request Checklist

Issue Description

Approach

TODOs before merging

parse-github-assistant bot commented Jun 29, 2023

parse-github-assistant bot commented Jun 29, 2023 • edited Loading

Thanks for opening this pull request!

uffizzi-cloud bot commented Jun 29, 2023

Uffizzi Ephemeral Environment deployment-29709

mtrezza commented Jun 29, 2023 • edited Loading

dblythy commented Jun 30, 2023 • edited Loading

mtrezza left a comment • edited Loading

Choose a reason for hiding this comment

mtrezza left a comment

Choose a reason for hiding this comment

mtrezza commented Jul 5, 2023 • edited Loading

dblythy commented Jul 18, 2023

mtrezza commented Jul 18, 2023

mtrezza left a comment

Choose a reason for hiding this comment

mtrezza commented Aug 27, 2023

uffizzi-cloud bot commented Feb 29, 2024

Uffizzi Ephemeral Environment deployment-47529

parseplatformorg commented Jun 27, 2024

parseplatformorg commented Oct 7, 2024

parseplatformorg commented Oct 7, 2024

parse-github-assistant bot commented Jun 29, 2023 •

edited

Loading

Uffizzi Ephemeral Environment `deployment-29709`

mtrezza commented Jun 29, 2023 •

edited

Loading

dblythy commented Jun 30, 2023 •

edited

Loading

mtrezza left a comment •

edited

Loading

mtrezza commented Jul 5, 2023 •

edited

Loading

Uffizzi Ephemeral Environment `deployment-47529`