Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): Refactor Dockerfile #683

Merged
merged 7 commits into from
Sep 8, 2024
Merged

Conversation

duhow
Copy link
Contributor

@duhow duhow commented Aug 30, 2024

  • Reduce build layers from 23 to 12
  • Add ARG PHP_VERSION to allow usage of different php versions (defaults to 8.1)
  • Reorder layers to allow common content to be reusable (layers) between different builds

Ideally composer can be in a separate RUN way, so if dependencies do not change, it can keep the same content from other builds, but I'm unable to setup this at the moment.

@jbtronics
Copy link
Member

Thank you. Looks good, I will review (and try it out) in detail later.

Maybe some of the changes can also be applied to the frankenphp Dockerfile (https://github.com/Part-DB/Part-DB-server/blob/master/Dockerfile-frankenphp), because in long term I would like to make the frankenphp version the default docker image, as the worker model is faster than the classic approach and frankenphp has some other builtin nice features.

@jbtronics jbtronics closed this Aug 30, 2024
@jbtronics jbtronics reopened this Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.32%. Comparing base (756152d) to head (b7406dc).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #683      +/-   ##
============================================
- Coverage     62.33%   62.32%   -0.02%     
  Complexity     5659     5659              
============================================
  Files           518      518              
  Lines         18708    18708              
============================================
- Hits          11662    11659       -3     
- Misses         7046     7049       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbtronics jbtronics merged commit b5a0189 into Part-DB:master Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants