Split attachment paths

[Treeed]

Since there is a tendency for online data to be lost it usually makes sense to generally download any external attachments. However, with the current configuration, the original link is lost, so there is no easy way to check e.g. if there was a change to the original file. Since I don't like throwing out data in bulk I needed a mechanism to retain both copies.

This PR splits the single "path" property into "internal_path" and "external_path" to achieve that. To keep the naming and handling of internal and external files consistent that spreads into quite a few files.

Sorry for the single huge commit, but there's really no in-between state where everything still works.

Some translations are required again. Since I still don't know how to do these I just added TODO tags. There's also some changes to the English translation file which would need to be propagated to the other languages.

I considered keeping the "media_url" key in the normalizer for compatibility, but it didn't work for external URLs in the first place, so I ended up just removing it.

Depends on PR #847

[codecov]

Codecov Report

Attention: Patch coverage is 65.10067% with 52 lines in your changes missing coverage. Please review.

Project coverage is 60.81%. Comparing base (d093721) to head (ceb7c7b).

Files with missing lines	Patch %	Lines
src/DataTables/AttachmentDataTable.php	69.69%	10 Missing ⚠️
src/Services/EntityURLGenerator.php	25.00%	9 Missing ⚠️
src/Controller/AttachmentFileController.php	0.00%	8 Missing ⚠️
...rc/Services/Attachments/AttachmentURLGenerator.php	22.22%	7 Missing ⚠️
...c/Services/Attachments/AttachmentSubmitHandler.php	45.45%	6 Missing ⚠️
src/Entity/Attachments/Attachment.php	91.66%	4 Missing ⚠️
src/Services/Attachments/AttachmentManager.php	72.72%	3 Missing ⚠️
src/EntityListeners/AttachmentDeleteListener.php	0.00%	2 Missing ⚠️
src/DataFixtures/PartFixtures.php	0.00%	1 Missing ⚠️
...c/Services/Attachments/AttachmentReverseSearch.php	0.00%	1 Missing ⚠️
... and 1 more

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #848      +/-   ##
============================================
- Coverage     60.85%   60.81%   -0.05%     
- Complexity     5931     5934       +3     
============================================
  Files           523      523              
  Lines         20089    20115      +26     
============================================
+ Hits          12225    12232       +7     
- Misses         7864     7883      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.