Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the disabling of delayed delivery #1422

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Allow the disabling of delayed delivery #1422

merged 3 commits into from
Aug 6, 2024

Conversation

WilliamBZA
Copy link
Member

@WilliamBZA WilliamBZA commented Aug 5, 2024 •
edited
Loading

Adds a constructor parameter to disable the creation of the delayed delivery infrastructure.

Use cases include:

  • Integration with existing systems
  • Prevent unnecessary creation of delayed delivery infrastructure when not needed (e.g. within ServiceControl)

@ramonsmits ramonsmits force-pushed the disable-delayed-infra branch from 14209b6 to 5e3327e Compare August 5, 2024 12:29
@WilliamBZA WilliamBZA marked this pull request as ready for review August 6, 2024 07:54
@WilliamBZA WilliamBZA changed the title Add a ctor option to not create the delayed delivery infrastructure Add a constructor parameter to not create the delayed delivery infrastructure Aug 6, 2024
@WilliamBZA WilliamBZA added this to the 9.1.0 milestone Aug 6, 2024
@WilliamBZA WilliamBZA merged commit ff6fce3 into master Aug 6, 2024
3 checks passed
@WilliamBZA WilliamBZA deleted the disable-delayed-infra branch August 6, 2024 10:37
@WilliamBZA WilliamBZA changed the title Add a constructor parameter to not create the delayed delivery infrastructure Add a constructor parameter to disable the creation of the delayed delivery infrastructure Aug 6, 2024
@WilliamBZA WilliamBZA changed the title Add a constructor parameter to disable the creation of the delayed delivery infrastructure Allow the disabling of delayed delivery Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irinascurtu irinascurtu irinascurtu approved these changes

@ramonsmits ramonsmits ramonsmits approved these changes

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
9.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@WilliamBZA @ramonsmits @irinascurtu @SzymonPobiega