Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Particular/setup-rabbitmq-action from 1.6.0 to 1.7.0 #1432

Merged
merged 2 commits into from
Aug 10, 2024
Merged

Bump Particular/setup-rabbitmq-action from 1.6.0 to 1.7.0 #1432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8293e3
Bump Particular/setup-rabbitmq-action from 1.6.0 to 1.7.0
dependabot[bot] Aug 10, 2024
bd0ec7b
Fix flaky tests
danielmarbach Aug 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
creds: ${{ secrets.AZURE_ACI_CREDENTIALS }}
enable-AzPSSession: true
- name: Setup RabbitMQ
uses: Particular/setup-rabbitmq-action@v1.6.0
uses: Particular/setup-rabbitmq-action@v1.7.0
with:
connection-string-name: RabbitMQTransport_ConnectionString
tag: RabbitMQTransport
Expand Down
7 changes: 6 additions & 1 deletion src/NServiceBus.Transport.RabbitMQ.TransportTests/When_changing_concurrency.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ public class When_changing_concurrency : NServiceBusTransportTest
public async Task Should_complete_current_message(TransportTransactionMode transactionMode)
{
var triggeredChangeConcurrency = CreateTaskCompletionSource();
var sentMessageReceived = CreateTaskCompletionSource();
Task concurrencyChanged = null;
int invocationCounter = 0;

Expand All @@ -30,6 +31,7 @@ await StartPump(async (context, ct) =>
await task;
}, ct);

sentMessageReceived.SetResult();
await triggeredChangeConcurrency.Task;

}, (_, _) =>
Expand All @@ -40,8 +42,10 @@ await StartPump(async (context, ct) =>
transactionMode);

await SendMessage(InputQueueName);
await sentMessageReceived.Task;
await concurrencyChanged;
await StopPump();

Assert.AreEqual(1, invocationCounter, "message should successfully complete on first processing attempt");
}

Expand All @@ -62,6 +66,7 @@ await StartPump((context, _) =>
if (context.Headers.TryGetValue("FromOnError", out var value) && value == bool.TrueString)
{
sentMessageReceived.SetResult();
return Task.CompletedTask;
}

throw new Exception("triggering recoverability pipeline");
Expand All @@ -84,9 +89,9 @@ await SendMessage(InputQueueName,
transactionMode);

await SendMessage(InputQueueName);

await sentMessageReceived.Task;
await StopPump();

Assert.AreEqual(2, invocationCounter, "there should be exactly 2 messages (initial message and new message from onError pipeline)");
}
}
Expand Down