Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive failures lock transport into single concurrency mode #1061

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

danielmarbach and others added 2 commits October 1, 2024 10:32
…explicit state transitions (#1057)

* Try address races in the repeated failure circuit breaker

* Address races in the repeated failure circuit breaker

* Improve log message

---------

Co-authored-by: danielmarbach <danielmarbach@users.noreply.github.com>
…h count to make sure during throttling the number of prefetched messages is kept aligned with the settings of the user (#1058)

Co-authored-by: danielmarbach <danielmarbach@users.noreply.github.com>
@DavidBoike DavidBoike added the Bug label Oct 1, 2024
@DavidBoike DavidBoike added this to the 3.2.5 milestone Oct 1, 2024
@DavidBoike DavidBoike changed the title Circuit breaker fixes 3.2 - will rename to bug name Receive failures lock transport into single concurrency mode Oct 1, 2024
@DavidBoike DavidBoike requested a review from awright18 October 1, 2024 15:56
* Use locks to serialize arm/disarm actions

* Explicit state lock, Volatile read of state outside lock, actually reduce nesting where possible

* Small cosmetics for better readability

* Better logging

* Verbose comment

* Even better logging

* Basic test coverage

---------

Co-authored-by: danielmarbach <danielmarbach@users.noreply.github.com>
@danielmarbach danielmarbach merged commit 8524599 into release-3.2 Oct 2, 2024
4 checks passed
@danielmarbach danielmarbach deleted the circuit-breaker-3.2 branch October 2, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants