Merge pull request #7289 from Particular/code-analysis-cleanup

Code analysis cleanup 8.2
Particular · Feb 12, 2025 · b7ddb40 · b7ddb40
2 parents 7173ee6 + cfeb50a
commit b7ddb40
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/src/NServiceBus.Core/Recoverability/IRecoverabilityActionContext.cs b/src/NServiceBus.Core/Recoverability/IRecoverabilityActionContext.cs
@@ -12,27 +12,27 @@ public interface IRecoverabilityActionContext : IBehaviorContext
         /// <summary>
         /// The message that failed processing.
         /// </summary>
-        public IncomingMessage FailedMessage { get; }
+        IncomingMessage FailedMessage { get; }
 
         /// <summary>
         /// The exception that caused processing to fail.
         /// </summary>
-        public Exception Exception { get; }
+        Exception Exception { get; }
 
         /// <summary>
         /// The receive address where this message failed.
         /// </summary>
-        public string ReceiveAddress { get; }
+        string ReceiveAddress { get; }
 
         /// <summary>
         /// The number of times the message have been retried immediately but failed.
         /// </summary>
-        public int ImmediateProcessingFailures { get; }
+        int ImmediateProcessingFailures { get; }
 
         /// <summary>
         /// Number of delayed deliveries performed so far.
         /// </summary>
-        public int DelayedDeliveriesPerformed { get; }
+        int DelayedDeliveriesPerformed { get; }
 
         /// <summary>
         /// Metadata for this message.

diff --git a/src/NServiceBus.Core/Recoverability/IRecoverabilityContext.cs b/src/NServiceBus.Core/Recoverability/IRecoverabilityContext.cs
@@ -12,32 +12,32 @@ public interface IRecoverabilityContext : IBehaviorContext
         /// <summary>
         /// The message that failed processing.
         /// </summary>
-        public IncomingMessage FailedMessage { get; }
+        IncomingMessage FailedMessage { get; }
 
         /// <summary>
         /// The exception that caused processing to fail.
         /// </summary>
-        public Exception Exception { get; }
+        Exception Exception { get; }
 
         /// <summary>
         /// The receive address where this message failed.
         /// </summary>
-        public string ReceiveAddress { get; }
+        string ReceiveAddress { get; }
 
         /// <summary>
         /// The number of times the message have been retried immediately but failed.
         /// </summary>
-        public int ImmediateProcessingFailures { get; }
+        int ImmediateProcessingFailures { get; }
 
         /// <summary>
         /// Number of delayed deliveries performed so far.
         /// </summary>
-        public int DelayedDeliveriesPerformed { get; }
+        int DelayedDeliveriesPerformed { get; }
 
         /// <summary>
         /// The recoverability configuration for the endpoint.
         /// </summary>
-        public RecoverabilityConfig RecoverabilityConfiguration { get; }
+        RecoverabilityConfig RecoverabilityConfiguration { get; }
 
         /// <summary>
         /// The recoverability action to take for this message.

diff --git a/src/NServiceBus.Core/Recoverability/RecoverabilityComponent.cs b/src/NServiceBus.Core/Recoverability/RecoverabilityComponent.cs
@@ -79,7 +79,7 @@ public IRecoverabilityPipelineExecutor CreateRecoverabilityPipelineExecutor(
             if (!settings.TryGet(PolicyOverride, out Func<RecoverabilityConfig, ErrorContext, RecoverabilityAction> policy))
             {
                 policy = (config, context) => DefaultRecoverabilityPolicy.Invoke(config, context);
-            };
+            }
 
             return new RecoverabilityPipelineExecutor<(RecoverabilityComponent,
                 Func<RecoverabilityConfig, ErrorContext, RecoverabilityAction>)>(