Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages processed by the Gateway satellite are being forwarded to the audit queue causing duplicates in the audit queue. #1699

Closed
indualagarsamy opened this issue Oct 22, 2013 · 6 comments
Assignees
Labels
Milestone

Comments

@indualagarsamy
Copy link
Contributor

Steps to Reproduce

  1. Run the gateway sample and click the Send Price update command button from the website
  2. Inspect the audit queue
  3. Notice that there are two messages for PriceUpdateReceived. One of the messages is the result of the Headquarter processing the message and this is correct and the message headers have the correct NServiceBus.ProcessingStarted and NServiceBus.ProcessingEnded stats. However, there is also another message and this is because the gateway satellite processed the Bus.Reply<PriceUpdateReceived> and this one does not have any stats. This is because UoWs are not run for satellites.

We should not be auditing messages that are processed by our satellites meant for internal use.

The following code is responsible for this behavior:
https://github.com/Particular/NServiceBus/blob/develop/src/NServiceBus.Core/Gateway/Sending/GatewaySender.cs#L109-110

We had this in 3.3.8 as well:
https://github.com/Particular/NServiceBus/blob/3.3.8/src/gateway/NServiceBus.Gateway/Sending/GatewaySender.cs#L108-109

@johnsimons
Copy link
Member

👍 to get rid of Auditing on the Gateway satellite

@johnsimons
Copy link
Member

Just so that others don't jump up and down about "we need to audit everything".
All business messages are being audited, all we saying is that "internal messages" (insternal messages are messages processed by inner queues) do not need to be auditted

@andreasohlund
Copy link
Member

Go for it

Sent from my iPhone

On 23 okt 2013, at 01:25, John Simons notifications@github.com wrote:

to get rid of Auditing on the Gateway satellite


Reply to this email directly or view it on GitHub.

@chrisbednarski
Copy link
Contributor

I'm fully in support of only main endpoint q being audited.
What about control messages going to main q (eg. subscribe, unsubscribe, worker ready)? These aren't business messages, so they won't be audited?

@johnsimons
Copy link
Member

Everything in the main queue gets audited

On 23 October 2013 17:08, chrisbednarski notifications@github.com wrote:

I'm fully in support of only main endpoint q being audited.
What about control messages going to main q (eg. subscribe, unsubscribe)?


Reply to this email directly or view it on GitHubhttps://github.com//issues/1699#issuecomment-26882496
.

Regards
John Simons
NServiceBus

@chrisbednarski
Copy link
Contributor

Sounds good @johnsimons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants