You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Run the gateway sample and click the Send Price update command button from the website
Inspect the audit queue
Notice that there are two messages for PriceUpdateReceived. One of the messages is the result of the Headquarter processing the message and this is correct and the message headers have the correct NServiceBus.ProcessingStarted and NServiceBus.ProcessingEnded stats. However, there is also another message and this is because the gateway satellite processed the Bus.Reply<PriceUpdateReceived> and this one does not have any stats. This is because UoWs are not run for satellites.
We should not be auditing messages that are processed by our satellites meant for internal use.
Just so that others don't jump up and down about "we need to audit everything".
All business messages are being audited, all we saying is that "internal messages" (insternal messages are messages processed by inner queues) do not need to be auditted
I'm fully in support of only main endpoint q being audited.
What about control messages going to main q (eg. subscribe, unsubscribe, worker ready)? These aren't business messages, so they won't be audited?
Steps to Reproduce
Send Price update command
button from the websitePriceUpdateReceived
. One of the messages is the result of the Headquarter processing the message and this is correct and the message headers have the correctNServiceBus.ProcessingStarted
andNServiceBus.ProcessingEnded
stats. However, there is also another message and this is because the gateway satellite processed theBus.Reply<PriceUpdateReceived>
and this one does not have any stats. This is because UoWs are not run for satellites.We should not be auditing messages that are processed by our satellites meant for internal use.
The following code is responsible for this behavior:
https://github.com/Particular/NServiceBus/blob/develop/src/NServiceBus.Core/Gateway/Sending/GatewaySender.cs#L109-110
We had this in 3.3.8 as well:
https://github.com/Particular/NServiceBus/blob/3.3.8/src/gateway/NServiceBus.Gateway/Sending/GatewaySender.cs#L108-109
The text was updated successfully, but these errors were encountered: