Bus.InMemory events now expect either unobtrusive conventions or IEvent interface markers

[indualagarsamy]

Steps to repro:

1. Declare a POCO for the inmemory event (not derived from IEvent), eg AuditMessageReceived
   https://github.com/Particular/ServiceControl/blob/develop/src/ServiceControl/Contracts/Operations/AuditMessageReceived.cs
2. In a message handler, do an - in memory raise for the above event.
   https://github.com/Particular/ServiceControl/blob/develop/src/ServiceControl/Infrastructure/Satellites/AuditMessageImportSatellite.cs#L15

Notice the exception:

A first chance exception of type 'System.Exception' occurred in NServiceBus.Core.dll
An exception of type 'System.Exception' occurred in NServiceBus.Core.dll but was not handled in user code
Additional information: Could not find Metadata for 'ServiceControl.Contracts.Operations.AuditMessageReceived'.
Please ensure the following:
1. 'ServiceControl.Contracts.Operations.AuditMessageReceived' is included in initial scanning see File Scanning: http://particular.net/articles/the-nservicebus-host
2. 'ServiceControl.Contracts.Operations.AuditMessageReceived' implements either 'IMessage', 'IEvent' or 'ICommand' or alternatively, if you don't want to implement an interface, you can use 'Unobtrusive Mode' see: http://particular.net/articles/unobtrusive-mode-messages

NOTE: This used to work in 4.2 without adding any marker interfaces to the POCOs for in-memory events.

[andreasohlund]

Based on a discussion with Indu today we believe that is can be a resonable
requirement and that we should consider changing this in 4.3 and point it
out clearly in the release notes?

On Tue, Nov 19, 2013 at 1:00 AM, Indu Alagarsamy
notifications@git.luolix.topwrote:

Steps to repro:

1. Declare a POCO for the inmemory event (not derived from IEvent), eg
   AuditMessageReceived

https://github.com/Particular/ServiceControl/blob/develop/src/ServiceControl/Contracts/Operations/AuditMessageReceived.cs

1. In a message handler, do an - in memory raise for the above event.
   https://github.com/Particular/ServiceControl/blob/develop/src/ServiceControl/Infrastructure/Satellites/AuditMessageImportSatellite.cs#L15

Notice the exception:

A first chance exception of type 'System.Exception' occurred in NServiceBus.Core.dll
An exception of type 'System.Exception' occurred in NServiceBus.Core.dll but was not handled in user code
Additional information: Could not find Metadata for 'ServiceControl.Contracts.Operations.AuditMessageReceived'.
Please ensure the following:

1. 'ServiceControl.Contracts.Operations.AuditMessageReceived' is included in initial scanning see File Scanning: http://particular.net/articles/the-nservicebus-host
2. 'ServiceControl.Contracts.Operations.AuditMessageReceived' implements either 'IMessage', 'IEvent' or 'ICommand' or alternatively, if you don't want to implement an interface, you can use 'Unobtrusive Mode' see: http://particular.net/articles/unobtrusive-mode-messages

NOTE: This used to work in 4.2 without adding any marker interfaces to the
POCOs for in-memory events.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1788
.

[johnsimons]

Even though it is a resonable requirement, it still is a breaking change
that is not backwards compatible, so we either bump it to v5 or make it
backwards compliant.

On Tuesday, November 19, 2013, Andreas Öhlund wrote:

Based on a discussion with Indu today we believe that is can be a
resonable
requirement and that we should consider changing this in 4.3 and point it
out clearly in the release notes?

On Tue, Nov 19, 2013 at 1:00 AM, Indu Alagarsamy
<notifications@github.com <javascript:_e({}, 'cvml',
'notifications@github.com');>>wrote:

Steps to repro:

1. Declare a POCO for the inmemory event (not derived from IEvent), eg
   AuditMessageReceived

https://github.com/Particular/ServiceControl/blob/develop/src/ServiceControl/Contracts/Operations/AuditMessageReceived.cs

1. In a message handler, do an - in memory raise for the above event.

https://github.com/Particular/ServiceControl/blob/develop/src/ServiceControl/Infrastructure/Satellites/AuditMessageImportSatellite.cs#L15

Notice the exception:

A first chance exception of type 'System.Exception' occurred in
NServiceBus.Core.dll
An exception of type 'System.Exception' occurred in NServiceBus.Core.dll
but was not handled in user code
Additional information: Could not find Metadata for
'ServiceControl.Contracts.Operations.AuditMessageReceived'.
Please ensure the following:

1. 'ServiceControl.Contracts.Operations.AuditMessageReceived' is
   included in initial scanning see File Scanning:
   http://particular.net/articles/the-nservicebus-host
2. 'ServiceControl.Contracts.Operations.AuditMessageReceived' implements
   either 'IMessage', 'IEvent' or 'ICommand' or alternatively, if you don't
   want to implement an interface, you can use 'Unobtrusive Mode' see:
   http://particular.net/articles/unobtrusive-mode-messages

NOTE: This used to work in 4.2 without adding any marker interfaces to
the
POCOs for in-memory events.

—
Reply to this email directly or view it on GitHub<
https://github.com/Particular/NServiceBus/issues/1788>
.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1788#issuecomment-28778169
.

Regards
John Simons
NServiceBus

[SimonCropp]

what @johnsimons said +1

[chrisbednarski]

Shouldn't convention checks be done only on the main transport queue?
Issue #1471 has some more comments