Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump NuDoq from 1.2.5 to 2.0.1 #5886

Merged
merged 3 commits into from
Jun 9, 2021
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 1, 2021

Bumps NuDoq from 1.2.5 to 2.0.1.

Release notes

Sourced from NuDoq's releases.

v2.0.1

v2.0.1 (2021-01-29)

Full Changelog

Implemented enhancements:

  • Project URL in the nuget package metadata is wrong #39

v2.0.0

v2.0.0 (2021-01-29)

Full Changelog

Implemented enhancements:

  • Add support for custom attributes in XmlVisitor #37
  • Add href to see and seealso #35
  • Improve readme to clarify usage #21

Fixed bugs:

  • Don't chop nonwhitespace when trimming text #33

v2.0.0-beta

v2.0.0-beta (2021-01-28)

Full Changelog

Fixed bugs:

  • On non-Windows OS, para render results in extra newlines #25
  • Fix missing methods with out/ref parameters #17
  • Fix nested enumeration of container elements #19
  • Fix indexed property visiting #22

Enhancements:

  • Enable newline preservation #20
  • Add support for extended documentation attributes #1
Changelog

Sourced from NuDoq's changelog.

v2.0.1 (2021-01-29)

Full Changelog

Implemented enhancements:

  • Project URL in the nuget package metadata is wrong #39

v2.0.0 (2021-01-29)

Full Changelog

Implemented enhancements:

  • Add support for custom attributes in XmlVisitor #37
  • Add href to see and seealso #35
  • Improve readme to clarify usage #21

Fixed bugs:

  • Don't chop nonwhitespace when trimming text #33

v2.0.0-beta (2021-01-28)

Full Changelog

Implemented enhancements:

  • Adding options to not trim new lines in text #20

Fixed bugs:

  • On non-Windows OS, para render results in extra newlines #25
  • Nested enumeration of one Container's Elements causes missing elements in outer enumerator #19
  • Methods with value type parameters passed by reference are missing #17
Commits
  • c2be4d4 Fix project URL in nuget metadata
  • 4f5cd51 🖆 Apply kzu/oss template via dotnet-file
  • 59bb902 🖉 Update changelog with v2.0.0
  • 87775f0 🖆 Apply kzu/oss template via dotnet-file
  • 8098dca Remove unused tag workflow
  • f020e3d 🖆 Apply kzu/oss template via dotnet-file
  • 513aaf9 @ Add support for custom attributes in XmlVisitor
  • 8139639 🕮 Improve readme with more code on usage
  • e430b6e 🔗 Adds href to see and seealso
  • b29aa5f ✂ Don't chop non-whitespace when trimming text
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @particularbot7.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 1, 2021
@dependabot dependabot bot force-pushed the dependabot/nuget/NuDoq-2.0.1 branch from 4df4e17 to 6236805 Compare February 10, 2021 10:37
@dependabot dependabot bot force-pushed the dependabot/nuget/NuDoq-2.0.1 branch from 6236805 to e7b05f3 Compare February 25, 2021 16:29
@adamralph
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/nuget/NuDoq-2.0.1 branch from e7b05f3 to 24f7f1a Compare February 28, 2021 16:25
@dependabot dependabot bot force-pushed the dependabot/nuget/NuDoq-2.0.1 branch from 24f7f1a to 3a5e3d3 Compare March 26, 2021 04:33
Copy link

@particularbot7 particularbot7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 26, 2021

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@dependabot dependabot bot force-pushed the dependabot/nuget/NuDoq-2.0.1 branch from 3a5e3d3 to b939836 Compare April 2, 2021 07:55
Copy link

@particularbot7 particularbot7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@dependabot dependabot bot force-pushed the dependabot/nuget/NuDoq-2.0.1 branch from b939836 to 1f0f7c4 Compare April 19, 2021 20:55
Copy link

@particularbot7 particularbot7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@dependabot dependabot bot force-pushed the dependabot/nuget/NuDoq-2.0.1 branch from 1f0f7c4 to 25b6716 Compare April 28, 2021 12:21
Copy link

@particularbot7 particularbot7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

Bumps [NuDoq](https://github.com/devlooped/NuDoq) from 1.2.5 to 2.0.1.
- [Release notes](https://github.com/devlooped/NuDoq/releases)
- [Changelog](https://github.com/devlooped/NuDoq/blob/main/changelog.md)
- [Commits](devlooped/NuDoq@v1.2.5...v2.0.1)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/nuget/NuDoq-2.0.1 branch from 25b6716 to 1edf5ff Compare May 26, 2021 14:22
@mikeminutillo
Copy link
Member

mikeminutillo commented Jun 9, 2021

Pretty sure that SimpleJson should be excluded from the documentation tests.

This is happening because NuDoq 2.0 is reading the empty <value/> element for the indexer properties. i.e.

<member name="P:SimpleJson.JsonObject.Item(System.Int32)">
  <summary>
    Gets the <see cref="T:System.Object"/> at the specified index.
  </summary>
  <value></value>
</member>
<member name="P:SimpleJson.JsonObject.Item(System.String)">
  <summary>
    Gets or sets the <see cref="T:System.Object"/> with the specified key.
  </summary>
  <value></value>
</member>

This was fixed in devlooped/NuDoq#22 which was released in 2.0 beta

@mikeminutillo mikeminutillo self-assigned this Jun 9, 2021
It is 3rd party code so we don't control the documentation it has
@dependabot dependabot bot merged commit 564e8f7 into master Jun 9, 2021
@dependabot dependabot bot deleted the dependabot/nuget/NuDoq-2.0.1 branch June 9, 2021 06:40
@mikeminutillo
Copy link
Member

The other missing period was (I believe) also the result of a bug that was fixed in NuDoq 2.0 beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants