Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark APIs that are removed in NServiceBus 8 as obsolete #6232

Merged
merged 3 commits into from
Jan 25, 2022
Merged

Mark APIs that are removed in NServiceBus 8 as obsolete #6232

merged 3 commits into from
Jan 25, 2022

Conversation

aleksandr-samila
Copy link
Member

@aleksandr-samila aleksandr-samila commented Jan 20, 2022 •
edited by DavidBoike
Loading

This PR marks APIs as obsolete which will be removed in NServiceBus 8.

Documentation: https://docs.particular.net/nservicebus/upgrades/7to8/dependency-injection

@aleksandr-samila aleksandr-samila marked this pull request as draft January 20, 2022 21:19
mikeminutillo
mikeminutillo requested changes Jan 21, 2022
View reviewed changes
Copy link
Member

@mikeminutillo mikeminutillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to move the APIApprovals.cs test file back to it's original location. It's non-standard to have it in the ApprovalFiles folder.

src/NServiceBus.Core/ObjectBuilder/ServiceProviderExtensions.cs Outdated Show resolved Hide resolved
@HEskandari
Copy link
Contributor

@mikeminutillo the file was incidentally moved. I have moved it back.

@mikeminutillo mikeminutillo marked this pull request as ready for review January 25, 2022 07:08
@mikeminutillo mikeminutillo merged commit 086efd9 into master Jan 25, 2022
@mikeminutillo mikeminutillo deleted the obsolete-api branch January 25, 2022 07:09
@DavidBoike DavidBoike added this to the 7.7.0 milestone Feb 3, 2022
@DavidBoike DavidBoike changed the title Obsolete APIs for next major Obsolete APIs that are removed in NServiceBus 8 Mar 3, 2022
@DavidBoike DavidBoike changed the title Obsolete APIs that are removed in NServiceBus 8 Mark APIs that are removed in NServiceBus 8 as obsolete Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeminutillo mikeminutillo mikeminutillo approved these changes

@HEskandari HEskandari Awaiting requested review from HEskandari

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
7.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@aleksandr-samila @HEskandari @mikeminutillo @DavidBoike