Unit of work instances may get incorrectly promoted to single instance lifetime #6458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmarbach
force-pushed
the
fix-common-object-builder-uow-scope
branch
from
957c144
to
65907cf
Compare
…we use InternalsVisibleTo
SzymonPobiega
approved these changes
Jul 19, 2022
timbussmann
approved these changes
Jul 20, 2022
src/NServiceBus.Core/ObjectBuilder/Common/CommonObjectBuilder.cs
Outdated
Show resolved
Hide resolved
…ve the correct IBuilder instance (#6460) * Resolve the current builder per instance to make it possible to resolve the correct IBuilder instance * InstancePerCall
tmasternak
approved these changes
Jul 20, 2022
danielmarbach
added a commit
that referenced
this pull request
Jul 20, 2022
* Add a number of tests for the common object builder behavior * Fix instance per uow resolved via builder * Remove local version of async local used in acceptance testing since we use InternalsVisibleTo * Remove the static * Move things into a property * Add a test that uses Task.Run to fetch within the same scope * Resolve the current builder per instance to make it possible to resolve the correct IBuilder instance (#6460) * Resolve the current builder per instance to make it possible to resolve the correct IBuilder instance * InstancePerCall * Rename to parent and move fields
danielmarbach
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6459 for release-7.7 branch