Add ability to open storage session outside the pipeline #6467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmarbach
force-pushed
the
storage-session-improvements
branch
from
d350a45
to
adcf5e3
Compare
danielmarbach
changed the title
danielmarbach
changed the title
danielmarbach
commented
Jul 22, 2022
...ceTests/Core/Persistence/When_a_persistence_does_not_provide_synchronized_storage_session.cs
Show resolved
Hide resolved
...viceBus.AcceptanceTests/Core/Persistence/When_a_persistence_provides_synchronized_session.cs
Show resolved
Hide resolved
...eTests/Core/Reliability/SynchronizedStorage/When_opening_storage_session_outside_pipeline.cs
Show resolved
Hide resolved
...viceBus.Core/Reliability/SynchronizedStorage/CompletableSynchronizedStorageSessionAdapter.cs
Outdated
Show resolved
Hide resolved
timbussmann
approved these changes
Jul 25, 2022
src/NServiceBus.Core/Pipeline/Incoming/LoadHandlersConnector.cs
Outdated
Show resolved
Hide resolved
Bring in feature dependency Approve API
… the completable one from outside the core
… we don't override Co-authored-by: Tomasz Masternak <tomasz.masternak@particular.net>
Co-authored-by: Tim Bussmann <timbussmann@users.noreply.github.com>
SzymonPobiega
force-pushed
the
storage-session-improvements
branch
from
6395997
to
9748513
Compare
* resolve storage session per call * only dispose session once * approve scope change in test * change registration back to same scope as the referenced type
* make the session adapter class public * Approve Co-authored-by: Daniel Marbach <daniel.marbach@openplace.net>
danielmarbach
force-pushed
the
storage-session-improvements
branch
from
c5e3fa8
to
eabce6c
Compare
tmasternak
approved these changes
Sep 9, 2022
danielmarbach
force-pushed
the
storage-session-improvements
branch
from
3535c34
to
8ca5586
Compare
danielmarbach
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This back ports the functionality of v8 to resolve a completable storage session from a child container and then open it for consumption outside the pipeline.
This behavior is required for the transactional session package.