Registering IAsyncDisposable implementations throws an InvalidOperationException #6658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sposed (#6650) * AcceptanceTest to verify scoped async disposable support * use CreateAsyncScope * Add Assert * Extend test for singletons * Owned builder should be disposed using async disposable * Async dispose token registration * Dispose stopping token source * Fix leaking token source * Enable nullable in RunningEndpointInstance to indicate case when builder is null * Make the externally managed mode more visible in the code * Coverage of externally and internally managed mode * Rename tests Co-authored-by: Simon <simon.cropp@gmail.com>
danielmarbach
force-pushed
the
async-disposable-backport
branch
from
8a9cb65
to
6d2e1f8
Compare
danielmarbach
commented
Jan 9, 2023
abparticular
approved these changes
Jan 10, 2023
danielmarbach
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6659
Backport of #6650 to
release-8.0