-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System.Text.Json serializer #6749
Conversation
LGTM apart from some missing API docs. |
so will you be writing a upgrade/transition guide for will you submit a PR to NServiceBus.Json with obsolete messages? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to mave the JSon package reference from
<ItemGroup Condition="'$(TargetFramework)' == 'net472'">
<PackageReference Include="System.Memory" Version="4.5.5" />
<PackageReference Include="System.Text.Json" Version="7.0.2" />
</ItemGroup>
to
<ItemGroup Label="Public dependencies">
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="7.0.0" />
<PackageReference Include="System.Diagnostics.DiagnosticSource" Version="7.0.2" />
<PackageReference Include="System.Security.Cryptography.Xml" Version="7.0.1" />
</ItemGroup>
? Then we would have the same JSON version in place for all TFMs
src/NServiceBus.Core/Serializers/SystemJson/JsonMessageSerializer.cs
Outdated
Show resolved
Hide resolved
src/NServiceBus.Core/Serializers/SystemJson/SystemJsonConfigurationExtensions.cs
Outdated
Show resolved
Hide resolved
src/NServiceBus.Core/Serializers/SystemJson/SystemJsonConfigurationExtensions.cs
Outdated
Show resolved
Hide resolved
src/NServiceBus.Core/Serializers/SystemJson/SystemJsonConfigurationExtensions.cs
Outdated
Show resolved
Hide resolved
Yes to all 😄 |
src/NServiceBus.Core/Serializers/SystemJson/SystemJsonSerializerSettings.cs
Show resolved
Hide resolved
src/NServiceBus.Core/Serializers/SystemJson/SystemJsonConfigurationExtensions.cs
Outdated
Show resolved
Hide resolved
src/NServiceBus.Core.Tests/ApprovalFiles/APIApprovals.ApproveNServiceBus.approved.txt
Outdated
Show resolved
Hide resolved
FYI @danielmarbach, decided not to apply the V7 package across the board. If we didn't have .NET Framework targets we would probably just not declare the dependency and use the in-box version, at least until we try to do something (like with the source generators) that requires a specific version. So if you close one eye and ignore the net472 stuff now, that's essentially what we have. |
Agreed. Currently we also are not using anything of the version specific things so it should be fine |
No description provided.