-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow outbox to be enabled for send only endpoints via an explicit opt-in setting #6750
Conversation
src/NServiceBus.AcceptanceTests/Core/Outbox/When_outbox_enabled_on_send_only.cs
Outdated
Show resolved
Hide resolved
src/NServiceBus.AcceptanceTests/Core/Outbox/When_outbox_enabled_on_send_only.cs
Outdated
Show resolved
Hide resolved
src/NServiceBus.Learning.AcceptanceTests/NServiceBus.Learning.AcceptanceTests.csproj
Show resolved
Hide resolved
src/NServiceBus.AcceptanceTests/Core/Outbox/When_outbox_enabled_on_send_only.cs
Outdated
Show resolved
Hide resolved
@danielmarbach should we enable sagas as well? https://github.com/Particular/NServiceBus/blob/master/src/NServiceBus.Core/Sagas/Sagas.cs#L33 The more I think about this I feel that both the outbox and sagas should depend on the storage session being enabled and that one in turn should look at send only or not? |
As far as I recall, synchronized storage is always enabled when either outbox or saga are activated because it is required to setup the DI part too.
I see no benefit for a sendonly endpoint to do that. You? |
Yea, since you need to receive messages (currently) in order to interact with sagas |
I've verified that this works for SQLP by adding the override and seeing that a send only endpoint is able to get data into the outbox table |
Given I just fixed the Audit behavior for send-only endpoints in #6740, are there any knock-on effects to having the Outbox run in https://github.com/Particular/NServiceBus/blob/master/src/NServiceBus.Core/Audit/Audit.cs#L19-L20 that should be considered? The endpoint is still send-only, not receiving messages, and therefore not creating an audit queue, so all is good, right? |
Yea |
😎👍Awesome |
Allows Particular/NServiceBus.TransactionalSession#96 to be implemented in the future.