-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace SimpleJson usage with System.Text.Json #6770
Conversation
@danielmarbach any theories on the test failures? |
One is the encoding of the diagnostic entries. The other one don't know yet |
729083c
to
3dce52f
Compare
For some reasons I couldn't figure out yet it seems we are now exposed to race problems on the saga persister. |
Saga issues were because System.Text.Json serializer does not "clip" the end of a file's output when you are writing to a read/write FileStream. You have to do |
Awesome. Nice find! |
Replaces the previous usage of SimpleJson in two places with System.Text.Json:
We have replaced in a number of downstream the simplejson usages as well and so far, they have been frictionless. For the learning persistence I don't think we give any guarantees, so if there is a breaking change (which is quite unlikely) then that wouldn't be the end of the world since it is not a production persister.
The startup diagnostic files get overwritten on each start so that is also not a problem.